Use the new safe read-txn-no-tls heed feature
#3952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curquiza
previously approved these changes
Jul 26, 2023
meili-bors bot
added a commit
that referenced
this pull request
Jul 26, 2023
3952: No more use the broken `sync-read-txn` heed feature r=curquiza a=Kerollmops [We recently found out](meilisearch/heed#191 (comment)) that the `read-sync-txn` heed feature was invalid and must be removed from this crate. We were declaring it in milli/meilisearch but, fortunately, not sharing the `RoTxn`s across threads 😮💨 This PR removes the `sync-read-txn` heed feature form the _Cargo.toml_ file. I will fix this in heed v0.20.0 and will fill a RustSec advisory in the meantime. Co-authored-by: Clément Renault <clement@meilisearch.com>
|
Build failed: |
|
It is failing due to the removal of the |
Kerollmops
force-pushed
the
remove-heed-security
branch
from
5ff7bb9
to
d8b47b6
Compare
Kerollmops
changed the title
sync-read-txn heed featureread-txn-no-tls heed feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently found out that the
read-sync-txnheed feature was invalid and must be removed from this crate. We were declaring it in milli/meilisearch but, fortunately, not sharing theRoTxns across threads 😮💨I recently introduced the
read-txn-no-tlsheed feature, which implementsRoTxn: Sendand allows multiple read transactions on a single thread (which we use).This PR replaces the
sync-read-txnheed feature with theread-txn-no-tlsone in the Cargo.toml file. I will fix this in heed v0.20.0 and will fill a RustSec advisory in the meantime.