Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom encoding/decoding errors #88

Closed
Kerollmops opened this issue Dec 29, 2020 · 1 comment · Fixed by #128
Closed

Support custom encoding/decoding errors #88

Kerollmops opened this issue Dec 29, 2020 · 1 comment · Fixed by #128
Labels
breaking A change that is breaking the semver enhancement New feature or request good first issue Good for newcomers
Milestone
v0.20.0

Comments

@Kerollmops
Copy link
Member

It would be better and easier to debug a program if the BytesEncoding and BytesDecoding traits could return any error type.

To do so we need to modify the Error enum and more specifically the Encoding and Decoding variants to wrap a Box<dyn Error>.
@Kerollmops Kerollmops added enhancement New feature or request good first issue Good for newcomers breaking A change that is breaking the semver labels Dec 29, 2020
@MarinPostma
Copy link
Contributor

funny, I spent 3 hours debugging an error caused by just that, where a serializing error occured in a SerdeJson...

@MarinPostma MarinPostma mentioned this issue Dec 31, 2020
Closed
This was referenced Jul 6, 2022
Closed
Merged
@Kerollmops Kerollmops added this to the v0.20.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking A change that is breaking the semver enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v0.20.0
2 participants
@Kerollmops @MarinPostma