Tenant token options is not import #582
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
502: Developer experience enhancements r=alallema a=brunoocasali - Set the indent_style to "space" instead of "tabs". - Enable test reports to be forwarded to Docker volume - Allow debugging output from env var. Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Change HTTP methods
Apply search changes
507: Replace Slack by Discord r=alallema a=meili-bot _This PR is auto-generated._ Replace Slack by Discord in README.md Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Add URLBuilder for query parameters
Apply tasks changes
Rename Result class to Results
514: Modify setup-java in ci workflow for v3 r=alallema a=alallema Following the update of `setup-java` to v3 the distribution is now required. It's throw an [error](https://github.com/meilisearch/meilisearch-java/actions/runs/3788961009/jobs/6442255873) ``` Run actions/setup-java@v3 with: java-version: 1.8 java-package: jdk check-latest: false server-id: github server-username: GITHUB_ACTOR server-password: GITHUB_TOKEN overwrite-settings: true job-status: success token: *** Error: Input required and not supplied: distribution ``` Co-authored-by: alallema <amelie@meilisearch.com>
Apply dumps changes
Co-authored-by: Amélie <alallema@users.noreply.github.com>
Co-authored-by: Amélie <alallema@users.noreply.github.com>
567: Changed `SearchRequest` initializations to builder in code-sample r=alallema a=PotatoDoge Changed SearchRequest initializations to builder insted of a constructor - Changed code-samples.meilisearch.yaml file, SearchRequestTest file and SearchTest file # Pull Request ## Related issue Fixes #<560 ## What does this PR do? - Changed SearchRequest initializations to builder insted of a constructor ## PR checklist Please check if your PR fulfills the following requirements: - [x ] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [ x] Have you read the contributing guidelines? - [ x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: bastian.prado <bastian.prado@encora.com>
Co-authored-by: Amélie <alallema@users.noreply.github.com>
Co-authored-by: Amélie <alallema@users.noreply.github.com>
Co-authored-by: Amélie <alallema@users.noreply.github.com>
568: Add support to the pagination setting customization at the index level r=alallema a=dennxa # Pull Request ## Related issue Fixes meilisearch#411 ## What does this PR do? - Add the new methods to customize pagination -GET /indexes/:index_uid/settings/pagination -PATCH /indexes/:index_uid/settings/pagination -DELETE /indexes/:index_uid/settings/pagination - Add tests ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [X] Have you read the contributing guidelines? - [X] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Denia Lomas <denia.98@hotmail.com> Co-authored-by: Denia Lomas <50151794+dennxa@users.noreply.github.com>
566: feat: created Task Status enum. r=alallema a=TheClerici # Pull Request Task status enum on model package, added on task and taskInfo and modified some tests. ## Related issue Fixes meilisearch#556 ## What does this PR do? * TaskStatus enum added in model directory * String status in the Task and TaskInfo class exchanged with new enum * Some tests rewritten with the new use of the enum ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! I have a question. While changing some test I found out that when trying to do .waitForTask a NullPointerException was happening, even tho this not affect directly to what I'm implementing I don't wanna move something that can make it break, I also built everything and tested with ./gradlew test and lint. This is a draft so maybe you can check it out and let me know what you think Co-authored-by: TheClerici <enrique_cle97@hotmail.com> Co-authored-by: Enrique Clerici <115318468+TheClerici@users.noreply.github.com>
570: add methods for sortable attributes settings r=alallema a=albajarazeth # Pull Request ## Related issue Fixes meilisearch#491 ## What does this PR do? It applies the code review suggested changes from the last pull request. - getSortableAttributesSettings - updateSortableAttributesSettings - resetSortableAttributesSettings - Add tests - Add sample in the code-sample file ## PR checklist Please check if your PR fulfills the following requirements: [yes] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? [yes] Have you read the contributing guidelines? [yes] Have you made sure that the title is accurate and descriptive of the changes? Co-authored-by: Alba <jarazethalba@gmail.com>
…sks' into 501-Improve_test_testClientGetTasks
569: improve testClientGetTasks() to avoid looping all elements r=alallema a=oraliahdz # Pull Request ## Related issue Fixes meilisearch#501 ## What does this PR do? - improves testClientGetTasks() to avoid looping all elements ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: oraliahdz <oralia.hernandez@hotmail.com> Co-authored-by: Oralia Hernandez <89615667+oraliahdz@users.noreply.github.com> Co-authored-by: Amélie <alallema@users.noreply.github.com>
Deletes the added files in the meili_data directory.
Update comments for the DELETE method. Co-authored-by: Amélie <alallema@users.noreply.github.com>
577: Add support to the faceting setting customization at the index level r=alallema a=MaAnCoSa # Pull Request ## Related issue Fixes meilisearch#412 ## What does this PR do? * Added new methods for faceting customization: -GET /indexes/:index_uid/settings/faceting -PATCH /indexes/:index_uid/settings/faceting -DELETE /indexes/:index_uid/settings/faceting * Added tests ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: “Manuel <“cota.manuel@rocketmail.com”> Co-authored-by: Manuel Cota <108767897+MaAnCoSa@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #<issue_number>
null
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!