Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update milli 0.29 #2468

Merged
merged 6 commits into from
Jun 8, 2022
Merged

Update milli 0.29 #2468

merged 6 commits into from
Jun 8, 2022

Conversation

ManyTheFish
Copy link
Member

@ManyTheFish ManyTheFish commented Jun 6, 2022 •
edited by curquiza
Loading

  • Update milli to 0.29
  • Integrate charabia
  • Set disabled_words to default when Index::exact_words returns None
  • Fix ranking rules integration test

fixes #2375
fixes #2144
fixes #2417
fixes #2407

Kerollmops
Kerollmops requested changes Jun 6, 2022
View reviewed changes
meilisearch-lib/src/index/index.rs Outdated Show resolved Hide resolved
@curquiza curquiza added this to the v0.28.0 milestone Jun 6, 2022
@ManyTheFish ManyTheFish force-pushed the update-milli-0.29 branch 2 times, most recently from 02325d6 to e6014c4 Compare June 6, 2022 17:04
@ManyTheFish ManyTheFish added the skip changelog The PR will not appear in the release changelogs label Jun 6, 2022
@ManyTheFish ManyTheFish marked this pull request as ready for review June 6, 2022 17:13
@curquiza curquiza removed the skip changelog The PR will not appear in the release changelogs label Jun 6, 2022
Kerollmops
Kerollmops previously approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this PR, it makes the code much easier to read, thank you!

bors merge

bors bot added a commit that referenced this pull request Jun 7, 2022
@bors @ManyTheFish
Merge #2468
ba7f54e 
2468: Update milli 0.29 r=Kerollmops a=ManyTheFish

- [x] Update milli to 0.29
- [x] Integrate charabia
- [x] Set disabled_words to default when Index::exact_words returns None
- [x] Fix ranking rules integration test


Co-authored-by: ManyTheFish <many@meilisearch.com>
@bors
Copy link
Contributor

bors bot commented Jun 7, 2022

Build failed:

@ManyTheFish
Copy link
Member Author

because windows wasn't ready for the v0.29, let's give it another chance.
bors merge

bors bot added a commit that referenced this pull request Jun 7, 2022
@bors @ManyTheFish
Merge #2468
4006e73 
2468: Update milli 0.29 r=ManyTheFish a=ManyTheFish

- [x] Update milli to 0.29
- [x] Integrate charabia
- [x] Set disabled_words to default when Index::exact_words returns None
- [x] Fix ranking rules integration test

fixes #2375
fixes #2144
fixes #2417

Co-authored-by: ManyTheFish <many@meilisearch.com>
@bors
Copy link
Contributor

bors bot commented Jun 7, 2022

Build failed:

@curquiza
Copy link
Member

curquiza commented Jun 7, 2022

bors merge

bors bot added a commit that referenced this pull request Jun 7, 2022
@bors @ManyTheFish
Merge #2468
d8cc786 
2468: Update milli 0.29 r=curquiza a=ManyTheFish

- [x] Update milli to 0.29
- [x] Integrate charabia
- [x] Set disabled_words to default when Index::exact_words returns None
- [x] Fix ranking rules integration test

fixes #2375
fixes #2144
fixes #2417

Co-authored-by: ManyTheFish <many@meilisearch.com>
@curquiza curquiza linked an issue Jun 7, 2022 that may be closed by this pull request
Improve ranking rules error message #2407
Closed
@bors
Copy link
Contributor

bors bot commented Jun 7, 2022

Build failed:

@ManyTheFish
Copy link
Member Author

Three times in a row. 🤔
It begins to be annoying. I will rebase.

@ManyTheFish
Copy link
Member Author

bors merge

bors bot added a commit that referenced this pull request Jun 7, 2022
@bors @ManyTheFish
Merge #2468
0383f5a 
2468: Update milli 0.29 r=ManyTheFish a=ManyTheFish

- [x] Update milli to 0.29
- [x] Integrate charabia
- [x] Set disabled_words to default when Index::exact_words returns None
- [x] Fix ranking rules integration test

fixes #2375
fixes #2144
fixes #2417
fixes #2407

Co-authored-by: ManyTheFish <many@meilisearch.com>
@bors
Copy link
Contributor

bors bot commented Jun 7, 2022

Build failed:

@ManyTheFish
Copy link
Member Author

Seriously? snapshots now? Ok round 9000:
bors merge

bors bot added a commit that referenced this pull request Jun 7, 2022
@bors @ManyTheFish
Merge #2468
d52726d 
2468: Update milli 0.29 r=ManyTheFish a=ManyTheFish

- [x] Update milli to 0.29
- [x] Integrate charabia
- [x] Set disabled_words to default when Index::exact_words returns None
- [x] Fix ranking rules integration test

fixes #2375
fixes #2144
fixes #2417
fixes #2407

Co-authored-by: ManyTheFish <many@meilisearch.com>
@bors
Copy link
Contributor

bors bot commented Jun 7, 2022

Build failed:

@curquiza
Copy link
Member

curquiza commented Jun 7, 2022

bors merge

bors bot added a commit that referenced this pull request Jun 8, 2022
@bors @ManyTheFish
Merge #2468
2f6c054 
2468: Update milli 0.29 r=ManyTheFish a=ManyTheFish

- [x] Update milli to 0.29
- [x] Integrate charabia
- [x] Set disabled_words to default when Index::exact_words returns None
- [x] Fix ranking rules integration test

fixes #2375
fixes #2144
fixes #2417
fixes #2407

Co-authored-by: ManyTheFish <many@meilisearch.com>
@bors
Copy link
Contributor

bors bot commented Jun 8, 2022

Build failed:

Kerollmops
Kerollmops previously approved these changes Jun 8, 2022
View reviewed changes
@ManyTheFish
Copy link
Member Author

please. 🤞

bors merge

bors bot added a commit that referenced this pull request Jun 8, 2022
@bors @ManyTheFish
Merge #2468
8224d06 
2468: Update milli 0.29 r=ManyTheFish a=ManyTheFish

- [x] Update milli to 0.29
- [x] Integrate charabia
- [x] Set disabled_words to default when Index::exact_words returns None
- [x] Fix ranking rules integration test

fixes #2375
fixes #2144
fixes #2417
fixes #2407

Co-authored-by: ManyTheFish <many@meilisearch.com>
@bors
Copy link
Contributor

bors bot commented Jun 8, 2022

Build failed:

@curquiza curquiza mentioned this pull request Jun 8, 2022
Closed
@ManyTheFish ManyTheFish force-pushed the update-milli-0.29 branch 3 times, most recently from 00eeac1 to 78b64b8 Compare June 8, 2022 13:28
@ManyTheFish ManyTheFish added enhancement New feature or improvement dependencies Pull requests that update a dependency file labels Jun 8, 2022
Kerollmops
Kerollmops approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incro :chocolatine: yable!
bors merge

@bors
Copy link
Contributor

bors bot commented Jun 8, 2022

Build succeeded:

@bors bors bot merged commit 6171f17 into main Jun 8, 2022
@bors bors bot deleted the update-milli-0.29 branch June 8, 2022 15:06
@curquiza curquiza mentioned this pull request Jun 8, 2022
Closed
@curquiza curquiza mentioned this pull request Jun 22, 2022
Closed
@curquiza curquiza added the v0.28.0 PRs/issues solved in v0.28.0 label Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerollmops Kerollmops Kerollmops approved these changes

@irevoire irevoire irevoire left review comments

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement New feature or improvement v0.28.0 PRs/issues solved in v0.28.0
Projects
None yet
Milestone
v0.28.0
4 participants
@ManyTheFish @curquiza @irevoire @Kerollmops