Improve ranking rules error message

[juchom]

Describe the bug
When changing the rules, the error message is misleading. According to the code :

meilisearch/meilisearch-http/tests/settings/get_settings.rs

Lines 285 to 290 in 6d22105

	let expected_error = json!({
	"message": r#"`manyTheFish` ranking rule is invalid. Valid ranking rules are Words, Typo, Sort, Proximity, Attribute, Exactness and custom ranking rules."#,
	"code": "invalid_ranking_rule",
	"type": "invalid_request",
	"link": "https://docs.meilisearch.com/errors#invalid_ranking_rule"
	});

Accepted rules are Words, Typo, Sort, Proximity, Attribute, Exactness in fact accepted rules are words, typo, sort, proximity, attribute, exactness

To Reproduce
Try sending a rule with a capital letter

Expected behavior
The rule name is case insensitive and the endpoint needs a fix and the error message is correct.

The rule name is case sensitive and the error message needs a fix to match this requirement.

Meilisearch version: [e.g. v0.27.1]

[curquiza]

Hello @juchom

Thanks for this report, I put it as good first issue. The change should be done on the milli's repo.
For any person who wants to contribute: feel free to ask any question or help 😄

PS: nice choice of test, @ManyTheFish can be proud 😇

[YanivDan]

hi
i think i found where to make the change is it in milli/milli/src/criterion.rs line 11?

option for a solution change the error message to :
#[error("{name} ranking rule is invalid. Valid ranking rules are Words, Typo, Sort, Proximity, Attribute, Exactness and custom ranking rules (with first capital letter). ")]

• the change is marked and italic typed

if true, pls notify me i would like to take this one :)

[MarinPostma]

hello @YanivDan, a PR has already been opened to address this issue here meilisearch/milli#536. Thanks for helping out!

[MarinPostma]

closed by meilisearch/milli#536

[curquiza]

I re-open, we will close it once the fix is available in Meilisearch 😊
Will be closed by #2468