-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
catFilter参数打印问题 #29
Comments
catFilter打印sql参数时,List,是按照list的顺序打印,并不是按照真实parameterIndex的位置打的,如果set参数不是按照顺序的化,打印的有问题 |
已修复 |
e,(?,?,?)调用:setString(3, '3')再setString(2, '2')再setString(1, '1')不会报错? |
使用Set记录实现Comparable,或是提供比较器给外面 |
从使用方式上来讲 先setString(3, '3')再setString(2, '2')再setString(1, '1') 并不是必要需求 |
我们的想法可能不一样,我的理解就是参数的打印顺序必须和sql里面的占位的顺序完全一致,而且没有文档标注必须按顺序进行参数设置,只要设置完全即可 另,如果不认同这个观点的话,建议还是不要修复了(交由别人的内部版本视情况修改),否则还会导致错误 |
2种方案都可以保证打印顺序 不过开源版本确实应该考虑好兼容性 这里我同意你的观点 |
这个问题不大。按照你的这个要求去实现有点复杂,建议还是保持现状。无伤大雅。 |
fix params ordering in pstmt in another way, fixes Meituan-Dianping#29
catFilter打印sql参数时,List
The text was updated successfully, but these errors were encountered: