Message Source should interpret messages.properties with no suffix as English #212
Assignees
Labels
Comments
mogoodrich
added a commit
to PIH/openmrs-module-initializer
that referenced
this issue
Dec 16, 2022
…ies with no suffix as Englis
|
PR here: #213 |
mogoodrich
added a commit
to PIH/openmrs-module-initializer
that referenced
this issue
Dec 16, 2022
…ies with no suffix as Englis
mogoodrich
added a commit
to PIH/openmrs-module-initializer
that referenced
this issue
Dec 16, 2022
…ies with no suffix as Englis
mogoodrich
added a commit
to PIH/openmrs-module-initializer
that referenced
this issue
Dec 16, 2022
…ies with no suffix as Englis
mogoodrich
added a commit
to PIH/openmrs-module-initializer
that referenced
this issue
Dec 19, 2022
…ies with no suffix as Englis
mogoodrich
added a commit
to PIH/openmrs-module-initializer
that referenced
this issue
Dec 20, 2022
…ies with no suffix as Englis
mks-d
pushed a commit
that referenced
this issue
Dec 21, 2022
* [#212] Message Source should interpret messages.properties with no suffix as Englis * [#212] Message Source should interpret messages.properties with no suffix as Englis * [#212] Message Source should interpret messages.properties with no suffix as Englis * [#212] Message Source should interpret messages.properties with no suffix as Englis * [#212] Message Source should interpret messages.properties with no suffix as Englis * [#212] Message Source should interpret messages.properties with no suffix as Englis
|
This was merged at e29810d Thanks so much @mogoodrich! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In OpenMRS, the convention is for the "default" messages properties files (ie messages.properties) to be in English.
However, the Message Source service in Initializer is set to interpret these files as being in the system default locale.
This is problematic. For example, on a server where the OS default is set to Spanish, the "messages.properties" will be added as Spanish keys, potentially overriding any actual translations provided in "messages_es.properties".
Additionally, since English is, by convention generally the only language there is guaranteed to be a translation for, and because generally we prefer display text in some language rather than raw message code, we should provide English as the final fallback when translating.
The text was updated successfully, but these errors were encountered: