-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#212] Locale-unspecified message properties to default to 'en' messages. #213
Conversation
…ies with no suffix as Englis
Closing this, this needs to be tweaked/fixed |
…ies with no suffix as Englis
…ies with no suffix as Englis
…ies with no suffix as Englis
My original PR preferred English over the default locale set via OpenMRS global property (and caused a test failure). New PR with what is hopefully the proper fix and a new test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment to remove a bad import. Also should add a bullet point to the release notes describing the change.
api/src/test/java/org/openmrs/module/initializer/InitializerMessageSourceIntegrationTest.java
Outdated
Show resolved
Hide resolved
…ies with no suffix as Englis
FYI, looks like the build error is unrelated to this commit? "Error: Failed to execute goal on project initializer-api-bahmni: Could not resolve dependencies for project org.openmrs.module:initializer-api-bahmni:jar:2.4.1-SNAPSHOT: The following artifacts could not be resolved: org.bahmni.module:bahmnicore-api:jar:0.93-1.1.0, org.openmrs.module:episodes-api:jar:1.0-1.0.0: Could not find artifact org.bahmni.module:bahmnicore-api:jar:0.93-1.1.0 in openmrs-repo (https://mavenrepo.openmrs.org/public) -> [Help 1]" |
…ies with no suffix as Englis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ffix as Englis