feat: remove Js.String2, use labeled arguments for Js.String #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmonteiro
commented
Nov 15, 2023
| return { | ||
| TAG: /* Eq */0, | ||
| _0: [ | ||
| "a", | ||
| "#", | ||
| undefined | ||
| ], | ||
| _1: "a#b#:c".split(/(#)(:)?/, 3) | ||
| _1: (function (param) { |
There was a problem hiding this comment.
expected since the test uses |>.
|
Before we merge this, we should add a test for string interpolation that fails in the current PR state. There's still a mention of Lines 463 to 464 in ac03e24 |
jchavarri
reviewed
Nov 15, 2023
| *) | ||
|
|
||
| (** [codePointAt n s] returns the code point at position [n] within string [s] as a [Some] value. The return value handles code points greater than or equal to [0x10000]. If there is no code point at the given position, the function returns [None]. | ||
| external codePointAt : t -> pos:int -> int option = "codePointAt" |
There was a problem hiding this comment.
Maybe can rename pos to index: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/codePointAt#index
There was a problem hiding this comment.
I used ~pos because that's what OCaml's StdLabels uses.
I like your suggestion. Check my reply in #895 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of the unification proposed in #731
this needs the melange v3 long-lived branch in reason-react to compile the template projects.