Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove Js.Array2, use labeled arguments for Js.Array #895

Merged
merged 4 commits into from
Nov 16, 2023
Merged

feat: remove Js.Array2, use labeled arguments for Js.Array #895

merged 4 commits into from
Nov 16, 2023

Conversation

anmonteiro
Copy link
Member

@anmonteiro anmonteiro commented Nov 15, 2023 •
edited

part of the unification proposed in #731

this needs the reasonml/reason-react#821 in reason-react to compile the template projects.

anmonteiro added a commit that referenced this pull request Nov 15, 2023
@anmonteiro
chore: add changelog entry for #893 and #895
62162d4
jchavarri
jchavarri reviewed Nov 15, 2023
View reviewed changes
Copy link
Member

@jchavarri jchavarri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I wonder if there's a chance to simplify the bindings by removing "dual" versions of the functions that can take optional args.

jscomp/runtime/js_array.ml Outdated Show resolved Hide resolved
jscomp/runtime/js_array.ml Outdated Show resolved Hide resolved
jscomp/runtime/js_array.ml Outdated Show resolved Hide resolved
jscomp/runtime/js_array.ml Outdated Show resolved Hide resolved
jscomp/runtime/js_array.ml Outdated Show resolved Hide resolved
jscomp/runtime/js_array.ml Outdated Show resolved Hide resolved
@anmonteiro anmonteiro mentioned this pull request Nov 15, 2023
Merged
@anmonteiro anmonteiro merged commit a154b01 into main Nov 16, 2023
2 of 4 checks passed
@anmonteiro anmonteiro deleted the anmonteiro/migrate-js-array branch November 16, 2023 21:44
anmonteiro added a commit that referenced this pull request Nov 16, 2023
@anmonteiro
feat: remove Js.String2, use labeled arguments for Js.String (#893)
3a4b2b1 
* feat: remove Js.String2, use labeled arguments for Js.String

* chore: add changelog entry for #893 and #895

* code review, fix tests

* fix: ci

* more code review fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchavarri jchavarri jchavarri left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anmonteiro @jchavarri