Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using scm or delivering, show link in report page #39

Open
thibaultduponchelle opened this issue Jan 4, 2021 · 9 comments
Open

Comments

@thibaultduponchelle
Copy link
Contributor

When building from scm, or delivering things during build, put links in report page.

@melezhik
Copy link
Owner

melezhik commented Jan 4, 2021

so, you want an SCM repo link on a build report, page, right?

@melezhik
Copy link
Owner

melezhik commented Jan 4, 2021

what is delivering?

@thibaultduponchelle
Copy link
Contributor Author

Yes.

Delivering : push tarballs somewhere for production deployment later

@melezhik
Copy link
Owner

melezhik commented Jan 4, 2021

So you suggest if a build produces any sort of tarball (for the future delivery/deployment) - add link to it as well? Those ones are not defined though a "spec" ( in comparison with scm which is a part of sparky.yaml ), the maximum we could do is to convert text into html links in a report. Or I miss your point?

@thibaultduponchelle
Copy link
Contributor Author

I will answer later better, it is between plug-in and UI. You can upload artefacts to github for instance : https://dev.to/davorg/archiving-cpan-logs-in-github-actions-2hfd or you can upload to artifactory, ftp, s3, whatever and push link to the CI system.

@thibaultduponchelle
Copy link
Contributor Author

I think the key is more about how plugins can pass extra infos to UI. I guess that currently it only returns logs.

@melezhik
Copy link
Owner

melezhik commented Jan 4, 2021

that's right. it's just a text file which is an output from a build process, no other structured info, that could be processed later in UI ...

@thibaultduponchelle
Copy link
Contributor Author

Can we think about returning structured info ? Like a json containing a key "log:" + eventually some others ?

It would maybe requires changes almost everywhere ?

@melezhik
Copy link
Owner

melezhik commented Jan 5, 2021

underlying spark job is just sparrowdo runs against either localhost/docker or ssh host that writes to file. For example:

sparrowdo --localhost > report.log

sparrowdo is not designed to return structured info, so it'd be hard to do ...

I don't know. Maybe I'll come up with some solutions later ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants