Error 'a' (<dimension1> x 1) must be square

[fweber144]

For some models fitted by mclogit::mblogit(), I get the error

Error in solve.default(X[[i]], ...) : 'a' (<dimension1> x 1) must be square

thrown by mclogit:::PQLMQL_innerFit(). (The <dimension1> can be 3, for example.)

I think the problematic line is

mclogit/pkg/R/mmclogit-fitPQLMQL.R

Line 271 in 7f47d53

S.k <- diag(x=S.k,nrow=d)

because, if S.k is a matrix there, then diag() returns a vector containing the diagonal elements. Perhaps that line was supposed to read

S.k <- diag(x=diag(S.k),nrow=d)

instead? But I don't know anything about the mathematical details of this line, so my guess might be completely wrong.

And I'm not sure, but perhaps this is the same bug as in #21?

Note that this issue occurs with both, the current CRAN version 0.8.7.3 as well as with the current GitHub version at commit 7f47d53 installed via devtools::install_github("melff/mclogit",subdir="pkg").

[Zhiwen-Owen-Jiang]

I found this bug either. The code that previously I could run failed.

[melff]

This appears to be fixed in release 0.9.4.

[fweber144]

Thanks, this seems indeed to be fixed. However, I now get an error from predict.mmblogit() which I'll open a new issue for.