Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to tabs.onActivated instead of onSelectionChanged #153

Closed
melink14 opened this issue Aug 28, 2019 · 1 comment · Fixed by #461
Closed

Switch to tabs.onActivated instead of onSelectionChanged #153

melink14 opened this issue Aug 28, 2019 · 1 comment · Fixed by #461
Assignees
@melink14
Labels
bug P1 released
Milestone
September 2020

Comments

@melink14
Copy link
Owner

onSelectionChanged is deprecated in favor of onActivated
https://developer.chrome.com/extensions/tabs#event-onActivated
@melink14 melink14 added this to the September 2020 milestone Sep 1, 2020
@melink14 melink14 self-assigned this Sep 6, 2020
melink14 added a commit that referenced this issue May 6, 2021
@melink14
fix: Migrate onSelectionChanged to onActivated
17781bd 
Fixes #153
@melink14 melink14 mentioned this issue May 6, 2021
Merged
melink14 added a commit that referenced this issue May 6, 2021
@melink14
fix: Migrate onSelectionChanged to onActivated (#461)
872fb70 
Fixes #153
melink14 added a commit that referenced this issue May 8, 2021
@melink14
fix: Migrate onSelectionChanged to onActivated (#461)
d8a0a9d 
Fixes #153
melink14 pushed a commit that referenced this issue May 10, 2021
@semantic-release-bot
chore(release): 1.1.0
e0d50c9 
## [1.1.0](v1.0.0...v1.1.0) (2021-05-10)

### Features

* **dict:** Update dictionaries ([#451](#451)) ([97e6306](97e6306))
* **dict:** Update dictionaries to latest versions. ([#469](#469)) ([96a6032](96a6032))

### Bug Fixes

* Change manifest.json description to be more descriptive. ([#268](#268)) ([5fb116c](5fb116c)), closes [#245](#245)
* Falsy setting values now correctly initialize. ([#408](#408)) ([327eecd](327eecd)), closes [#346](#346)
* Migrate `onSelectionChanged` to `onActivated` ([#461](#461)) ([d8a0a9d](d8a0a9d)), closes [#153](#153)
* Remove unneeded tabs permission from manifest. ([#266](#266)) ([d529e62](d529e62)), closes [#152](#152)
* Reset badge text to empty on extension startup ([#462](#462)) ([b4afd3f](b4afd3f)), closes [#82](#82)
* Update manifest.json to allow rikaikun to work in srcdoc iframes. ([#411](#411)) ([093824b](093824b)), closes [#410](#410)
melink14 pushed a commit that referenced this issue May 11, 2021
@semantic-release-bot
chore(release): 1.1.0
480e1a3 
## [1.1.0](v1.0.0...v1.1.0) (2021-05-11)

### Features

* **dict:** Update dictionaries ([#451](#451)) ([97e6306](97e6306))
* **dict:** Update dictionaries to latest versions. ([#469](#469)) ([96a6032](96a6032))

### Bug Fixes

* Change manifest.json description to be more descriptive. ([#268](#268)) ([5fb116c](5fb116c)), closes [#245](#245)
* Falsy setting values now correctly initialize. ([#408](#408)) ([327eecd](327eecd)), closes [#346](#346)
* Migrate `onSelectionChanged` to `onActivated` ([#461](#461)) ([d8a0a9d](d8a0a9d)), closes [#153](#153)
* Remove unneeded tabs permission from manifest. ([#266](#266)) ([d529e62](d529e62)), closes [#152](#152)
* Reset badge text to empty on extension startup ([#462](#462)) ([b4afd3f](b4afd3f)), closes [#82](#82)
* Update manifest.json to allow rikaikun to work in srcdoc iframes. ([#411](#411)) ([093824b](093824b)), closes [#410](#410)
melink14 pushed a commit that referenced this issue May 11, 2021
@semantic-release-bot
chore(release): 1.1.0
ec7f97a 
## [1.1.0](v1.0.0...v1.1.0) (2021-05-11)

### Features

* **dict:** Update dictionaries ([#451](#451)) ([97e6306](97e6306))
* **dict:** Update dictionaries to latest versions. ([#469](#469)) ([96a6032](96a6032))

### Bug Fixes

* Change manifest.json description to be more descriptive. ([#268](#268)) ([5fb116c](5fb116c)), closes [#245](#245)
* Falsy setting values now correctly initialize. ([#408](#408)) ([327eecd](327eecd)), closes [#346](#346)
* Migrate `onSelectionChanged` to `onActivated` ([#461](#461)) ([d8a0a9d](d8a0a9d)), closes [#153](#153)
* Remove unneeded tabs permission from manifest. ([#266](#266)) ([d529e62](d529e62)), closes [#152](#152)
* Reset badge text to empty on extension startup ([#462](#462)) ([b4afd3f](b4afd3f)), closes [#82](#82)
* Update manifest.json to allow rikaikun to work in srcdoc iframes. ([#411](#411)) ([093824b](093824b)), closes [#410](#410)
melink14 pushed a commit that referenced this issue May 11, 2021
@semantic-release-bot
chore(release): 1.1.0
96d60cb 
## [1.1.0](v1.0.0...v1.1.0) (2021-05-11)

### Features

* **dict:** Update dictionaries ([#451](#451)) ([97e6306](97e6306))
* **dict:** Update dictionaries to latest versions. ([#469](#469)) ([96a6032](96a6032))

### Bug Fixes

* **manifest:** Edit the manifest description to fit under the character limit ([de5a21a](de5a21a))
* Change manifest.json description to be more descriptive. ([#268](#268)) ([5fb116c](5fb116c)), closes [#245](#245)
* Falsy setting values now correctly initialize. ([#408](#408)) ([327eecd](327eecd)), closes [#346](#346)
* Migrate `onSelectionChanged` to `onActivated` ([#461](#461)) ([d8a0a9d](d8a0a9d)), closes [#153](#153)
* Remove unneeded tabs permission from manifest. ([#266](#266)) ([d529e62](d529e62)), closes [#152](#152)
* Reset badge text to empty on extension startup ([#462](#462)) ([b4afd3f](b4afd3f)), closes [#82](#82)
* Update manifest.json to allow rikaikun to work in srcdoc iframes. ([#411](#411)) ([093824b](093824b)), closes [#410](#410)
@melink14
Copy link
Owner Author

🎉 This issue has been resolved in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melink14 melink14

Labels
bug P1 released
Projects
None yet
Milestone
September 2020
Development

Successfully merging a pull request may close this issue.

fix: Migrate onSelectionChanged to onActivated melink14/rikaikun
1 participant
@melink14