Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Options initialization fails for falsy values #346

Closed
melink14 opened this issue Nov 30, 2020 · 2 comments · Fixed by #408
Closed

Options initialization fails for falsy values #346

melink14 opened this issue Nov 30, 2020 · 2 comments · Fixed by #408
Labels
bug easy good first issue

Comments

@melink14
Copy link
Owner

melink14 commented Nov 30, 2020 •
edited
Loading

This only affects boolean values (or numeric values that can take 0) that default to a value other than false but should be corrected to be an explicit check.

Nevermind, my specific problem is because this line:

rikaikun/extension/background.ts

Line 94 in bb011dc

cloudStorage[key] || normalizeStringValue(localStorage[key]);

When the stored value is false, it'll always fallback to default.

Originally posted by @nanaya in #333 (comment)
@melink14 melink14 mentioned this issue Nov 30, 2020
Open
@melink14
Copy link
Owner Author

melink14 commented Dec 1, 2020

Also from nanaya:

Yes. Thanks. On newer typescript replacing || with ?? should be enough to fix it.

@melink14
Copy link
Owner Author

melink14 commented Dec 2, 2020

Should also check and test the kanjiinfo settings:

rikaikun/extension/background.ts

Line 127 in bb011dc

if (cloudStorage.kanjiInfo && cloudStorage.kanjiInfo[kanjiInfoKey]) {

@melink14 melink14 mentioned this issue Mar 5, 2021
Closed
@melink14 melink14 mentioned this issue Apr 5, 2021
Closed
@SamDunlap SamDunlap mentioned this issue Apr 22, 2021
Merged
melink14 pushed a commit that referenced this issue Apr 23, 2021
@SamDunlap
fix: Falsy setting values now correctly initialize. (#408)
327eecd 
I changed the logic that checks whether or not initial options values exist and whether or not they are true, to only check for whether or not they exist already. This way, if a false value for a checkbox is not mistaken for a missing setting value.

Solves issue #346.
@melink14 melink14 linked a pull request May 6, 2021 that will close this issue
fix: Falsy setting values now correctly initialize. #408
Merged
@melink14 melink14 closed this as completed May 6, 2021
melink14 pushed a commit that referenced this issue May 10, 2021
@semantic-release-bot
chore(release): 1.1.0
e0d50c9 
## [1.1.0](v1.0.0...v1.1.0) (2021-05-10)

### Features

* **dict:** Update dictionaries ([#451](#451)) ([97e6306](97e6306))
* **dict:** Update dictionaries to latest versions. ([#469](#469)) ([96a6032](96a6032))

### Bug Fixes

* Change manifest.json description to be more descriptive. ([#268](#268)) ([5fb116c](5fb116c)), closes [#245](#245)
* Falsy setting values now correctly initialize. ([#408](#408)) ([327eecd](327eecd)), closes [#346](#346)
* Migrate `onSelectionChanged` to `onActivated` ([#461](#461)) ([d8a0a9d](d8a0a9d)), closes [#153](#153)
* Remove unneeded tabs permission from manifest. ([#266](#266)) ([d529e62](d529e62)), closes [#152](#152)
* Reset badge text to empty on extension startup ([#462](#462)) ([b4afd3f](b4afd3f)), closes [#82](#82)
* Update manifest.json to allow rikaikun to work in srcdoc iframes. ([#411](#411)) ([093824b](093824b)), closes [#410](#410)
melink14 pushed a commit that referenced this issue May 11, 2021
@semantic-release-bot
chore(release): 1.1.0
480e1a3 
## [1.1.0](v1.0.0...v1.1.0) (2021-05-11)

### Features

* **dict:** Update dictionaries ([#451](#451)) ([97e6306](97e6306))
* **dict:** Update dictionaries to latest versions. ([#469](#469)) ([96a6032](96a6032))

### Bug Fixes

* Change manifest.json description to be more descriptive. ([#268](#268)) ([5fb116c](5fb116c)), closes [#245](#245)
* Falsy setting values now correctly initialize. ([#408](#408)) ([327eecd](327eecd)), closes [#346](#346)
* Migrate `onSelectionChanged` to `onActivated` ([#461](#461)) ([d8a0a9d](d8a0a9d)), closes [#153](#153)
* Remove unneeded tabs permission from manifest. ([#266](#266)) ([d529e62](d529e62)), closes [#152](#152)
* Reset badge text to empty on extension startup ([#462](#462)) ([b4afd3f](b4afd3f)), closes [#82](#82)
* Update manifest.json to allow rikaikun to work in srcdoc iframes. ([#411](#411)) ([093824b](093824b)), closes [#410](#410)
melink14 pushed a commit that referenced this issue May 11, 2021
@semantic-release-bot
chore(release): 1.1.0
ec7f97a 
## [1.1.0](v1.0.0...v1.1.0) (2021-05-11)

### Features

* **dict:** Update dictionaries ([#451](#451)) ([97e6306](97e6306))
* **dict:** Update dictionaries to latest versions. ([#469](#469)) ([96a6032](96a6032))

### Bug Fixes

* Change manifest.json description to be more descriptive. ([#268](#268)) ([5fb116c](5fb116c)), closes [#245](#245)
* Falsy setting values now correctly initialize. ([#408](#408)) ([327eecd](327eecd)), closes [#346](#346)
* Migrate `onSelectionChanged` to `onActivated` ([#461](#461)) ([d8a0a9d](d8a0a9d)), closes [#153](#153)
* Remove unneeded tabs permission from manifest. ([#266](#266)) ([d529e62](d529e62)), closes [#152](#152)
* Reset badge text to empty on extension startup ([#462](#462)) ([b4afd3f](b4afd3f)), closes [#82](#82)
* Update manifest.json to allow rikaikun to work in srcdoc iframes. ([#411](#411)) ([093824b](093824b)), closes [#410](#410)
melink14 pushed a commit that referenced this issue May 11, 2021
@semantic-release-bot
chore(release): 1.1.0
96d60cb 
## [1.1.0](v1.0.0...v1.1.0) (2021-05-11)

### Features

* **dict:** Update dictionaries ([#451](#451)) ([97e6306](97e6306))
* **dict:** Update dictionaries to latest versions. ([#469](#469)) ([96a6032](96a6032))

### Bug Fixes

* **manifest:** Edit the manifest description to fit under the character limit ([de5a21a](de5a21a))
* Change manifest.json description to be more descriptive. ([#268](#268)) ([5fb116c](5fb116c)), closes [#245](#245)
* Falsy setting values now correctly initialize. ([#408](#408)) ([327eecd](327eecd)), closes [#346](#346)
* Migrate `onSelectionChanged` to `onActivated` ([#461](#461)) ([d8a0a9d](d8a0a9d)), closes [#153](#153)
* Remove unneeded tabs permission from manifest. ([#266](#266)) ([d529e62](d529e62)), closes [#152](#152)
* Reset badge text to empty on extension startup ([#462](#462)) ([b4afd3f](b4afd3f)), closes [#82](#82)
* Update manifest.json to allow rikaikun to work in srcdoc iframes. ([#411](#411)) ([093824b](093824b)), closes [#410](#410)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug easy good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Falsy setting values now correctly initialize. SamDunlap/rikaikun
1 participant
@melink14