Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"On" icon incorrectly displayed on startup #82

Closed
GoogleCodeExporter opened this issue Jun 13, 2015 · 7 comments · Fixed by #462
Closed

"On" icon incorrectly displayed on startup #82

GoogleCodeExporter opened this issue Jun 13, 2015 · 7 comments · Fixed by #462
Assignees
@melink14
Labels
bug P1 released
Milestone
September 2020

Comments

@GoogleCodeExporter
Copy link
Contributor 

What steps will reproduce the problem?
1. Open chrome for first time
2. "On" icon displayed
3. Confirm that rikaikun is not actually on
4. Press the rikai button again to turn on
5. Observe that icon remains in "on" state and rikai kun is actually on

What is the expected output? What do you see instead?
Expect the icon to not display on when rikai kun is not on


What version of the product are you using? On what operating system?
 0.8.5
on chrome 22.0.1229.94 m
and windows 7 x86

Original issue reported on code.google.com by perceptu...@gmail.com on 15 Oct 2012 at 4:22
@GoogleCodeExporter
Copy link
Contributor Author 

Same issue here. It's not a game-breaker, but this bug can be quite confusing 
at times.

Original comment by michael....@gmail.com on 24 Dec 2012 at 12:39

@GoogleCodeExporter
Copy link
Contributor Author 

This is very annoying.  It used to display on or off status fine.  I recommend 
making this a higher priority.  I want to say sometimes even when I click the 
toolbar icon to turn it on or off, it doesn't do anything.  I think this issue 
may be more than just at startup.

Affects all my computers.  W7 64, 32

Original comment by aa...@pcrequest.com on 5 Jan 2013 at 11:09

@melink14
Copy link
Owner

melink14 commented Mar 3, 2018

I think this is fixed at head...

@melink14
Copy link
Owner

Feel like I still see this so we need to confirm.

@melink14 melink14 added this to the September 2020 milestone Sep 4, 2020
@melink14
Copy link
Owner

melink14 commented Sep 4, 2020

Confirm on fresh chrome starts it tends to happen. (or maybe just the first installation)

@melink14
Copy link
Owner

melink14 commented May 6, 2021

It seems that the badge state is preserved across restarts; so if it was on it will remain on; however since rikaikun always starts off, it means it's out of sync.

@melink14 melink14 self-assigned this May 6, 2021
melink14 added a commit that referenced this issue May 6, 2021
@melink14
fix: Reset badge text to empty on extension startup
3d3a40c 
For some reason, chrome restores the previous badge state on restart causing inconsistency with actual rikaikun state.

Fixes #82
@melink14 melink14 mentioned this issue May 6, 2021
Merged
@mergify mergify bot closed this as completed in #462 May 6, 2021
mergify bot pushed a commit that referenced this issue May 6, 2021
@melink14
fix: Reset badge text to empty on extension startup (#462)
1e4647a 
For some reason, chrome restores the previous badge state on restart causing inconsistency with actual rikaikun state.

TESTED=Loaded unpacked extension and used chrome://restart to ensure badge text reset.
Fixes #82
melink14 added a commit that referenced this issue May 8, 2021
@melink14
fix: Reset badge text to empty on extension startup (#462)
b4afd3f 
For some reason, chrome restores the previous badge state on restart causing inconsistency with actual rikaikun state.

TESTED=Loaded unpacked extension and used chrome://restart to ensure badge text reset.
Fixes #82
melink14 pushed a commit that referenced this issue May 10, 2021
@semantic-release-bot
chore(release): 1.1.0
e0d50c9 
## [1.1.0](v1.0.0...v1.1.0) (2021-05-10)

### Features

* **dict:** Update dictionaries ([#451](#451)) ([97e6306](97e6306))
* **dict:** Update dictionaries to latest versions. ([#469](#469)) ([96a6032](96a6032))

### Bug Fixes

* Change manifest.json description to be more descriptive. ([#268](#268)) ([5fb116c](5fb116c)), closes [#245](#245)
* Falsy setting values now correctly initialize. ([#408](#408)) ([327eecd](327eecd)), closes [#346](#346)
* Migrate `onSelectionChanged` to `onActivated` ([#461](#461)) ([d8a0a9d](d8a0a9d)), closes [#153](#153)
* Remove unneeded tabs permission from manifest. ([#266](#266)) ([d529e62](d529e62)), closes [#152](#152)
* Reset badge text to empty on extension startup ([#462](#462)) ([b4afd3f](b4afd3f)), closes [#82](#82)
* Update manifest.json to allow rikaikun to work in srcdoc iframes. ([#411](#411)) ([093824b](093824b)), closes [#410](#410)
melink14 pushed a commit that referenced this issue May 11, 2021
@semantic-release-bot
chore(release): 1.1.0
480e1a3 
## [1.1.0](v1.0.0...v1.1.0) (2021-05-11)

### Features

* **dict:** Update dictionaries ([#451](#451)) ([97e6306](97e6306))
* **dict:** Update dictionaries to latest versions. ([#469](#469)) ([96a6032](96a6032))

### Bug Fixes

* Change manifest.json description to be more descriptive. ([#268](#268)) ([5fb116c](5fb116c)), closes [#245](#245)
* Falsy setting values now correctly initialize. ([#408](#408)) ([327eecd](327eecd)), closes [#346](#346)
* Migrate `onSelectionChanged` to `onActivated` ([#461](#461)) ([d8a0a9d](d8a0a9d)), closes [#153](#153)
* Remove unneeded tabs permission from manifest. ([#266](#266)) ([d529e62](d529e62)), closes [#152](#152)
* Reset badge text to empty on extension startup ([#462](#462)) ([b4afd3f](b4afd3f)), closes [#82](#82)
* Update manifest.json to allow rikaikun to work in srcdoc iframes. ([#411](#411)) ([093824b](093824b)), closes [#410](#410)
melink14 pushed a commit that referenced this issue May 11, 2021
@semantic-release-bot
chore(release): 1.1.0
ec7f97a 
## [1.1.0](v1.0.0...v1.1.0) (2021-05-11)

### Features

* **dict:** Update dictionaries ([#451](#451)) ([97e6306](97e6306))
* **dict:** Update dictionaries to latest versions. ([#469](#469)) ([96a6032](96a6032))

### Bug Fixes

* Change manifest.json description to be more descriptive. ([#268](#268)) ([5fb116c](5fb116c)), closes [#245](#245)
* Falsy setting values now correctly initialize. ([#408](#408)) ([327eecd](327eecd)), closes [#346](#346)
* Migrate `onSelectionChanged` to `onActivated` ([#461](#461)) ([d8a0a9d](d8a0a9d)), closes [#153](#153)
* Remove unneeded tabs permission from manifest. ([#266](#266)) ([d529e62](d529e62)), closes [#152](#152)
* Reset badge text to empty on extension startup ([#462](#462)) ([b4afd3f](b4afd3f)), closes [#82](#82)
* Update manifest.json to allow rikaikun to work in srcdoc iframes. ([#411](#411)) ([093824b](093824b)), closes [#410](#410)
melink14 pushed a commit that referenced this issue May 11, 2021
@semantic-release-bot
chore(release): 1.1.0
96d60cb 
## [1.1.0](v1.0.0...v1.1.0) (2021-05-11)

### Features

* **dict:** Update dictionaries ([#451](#451)) ([97e6306](97e6306))
* **dict:** Update dictionaries to latest versions. ([#469](#469)) ([96a6032](96a6032))

### Bug Fixes

* **manifest:** Edit the manifest description to fit under the character limit ([de5a21a](de5a21a))
* Change manifest.json description to be more descriptive. ([#268](#268)) ([5fb116c](5fb116c)), closes [#245](#245)
* Falsy setting values now correctly initialize. ([#408](#408)) ([327eecd](327eecd)), closes [#346](#346)
* Migrate `onSelectionChanged` to `onActivated` ([#461](#461)) ([d8a0a9d](d8a0a9d)), closes [#153](#153)
* Remove unneeded tabs permission from manifest. ([#266](#266)) ([d529e62](d529e62)), closes [#152](#152)
* Reset badge text to empty on extension startup ([#462](#462)) ([b4afd3f](b4afd3f)), closes [#82](#82)
* Update manifest.json to allow rikaikun to work in srcdoc iframes. ([#411](#411)) ([093824b](093824b)), closes [#410](#410)
@melink14
Copy link
Owner

🎉 This issue has been resolved in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melink14 melink14

Labels
bug P1 released
Projects
None yet
Milestone
September 2020
Development

Successfully merging a pull request may close this issue.

fix: Reset badge text to empty on extension startup melink14/rikaikun
2 participants
@melink14 @GoogleCodeExporter