fix: Update manifest.json to allow rikaikun to work in srcdoc iframes. #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melink14
changed the title
melink14
pushed a commit
that referenced
this pull request
May 10, 2021
## [1.1.0](v1.0.0...v1.1.0) (2021-05-10) ### Features * **dict:** Update dictionaries ([#451](#451)) ([97e6306](97e6306)) * **dict:** Update dictionaries to latest versions. ([#469](#469)) ([96a6032](96a6032)) ### Bug Fixes * Change manifest.json description to be more descriptive. ([#268](#268)) ([5fb116c](5fb116c)), closes [#245](#245) * Falsy setting values now correctly initialize. ([#408](#408)) ([327eecd](327eecd)), closes [#346](#346) * Migrate `onSelectionChanged` to `onActivated` ([#461](#461)) ([d8a0a9d](d8a0a9d)), closes [#153](#153) * Remove unneeded tabs permission from manifest. ([#266](#266)) ([d529e62](d529e62)), closes [#152](#152) * Reset badge text to empty on extension startup ([#462](#462)) ([b4afd3f](b4afd3f)), closes [#82](#82) * Update manifest.json to allow rikaikun to work in srcdoc iframes. ([#411](#411)) ([093824b](093824b)), closes [#410](#410)
melink14
pushed a commit
that referenced
this pull request
May 11, 2021
## [1.1.0](v1.0.0...v1.1.0) (2021-05-11) ### Features * **dict:** Update dictionaries ([#451](#451)) ([97e6306](97e6306)) * **dict:** Update dictionaries to latest versions. ([#469](#469)) ([96a6032](96a6032)) ### Bug Fixes * Change manifest.json description to be more descriptive. ([#268](#268)) ([5fb116c](5fb116c)), closes [#245](#245) * Falsy setting values now correctly initialize. ([#408](#408)) ([327eecd](327eecd)), closes [#346](#346) * Migrate `onSelectionChanged` to `onActivated` ([#461](#461)) ([d8a0a9d](d8a0a9d)), closes [#153](#153) * Remove unneeded tabs permission from manifest. ([#266](#266)) ([d529e62](d529e62)), closes [#152](#152) * Reset badge text to empty on extension startup ([#462](#462)) ([b4afd3f](b4afd3f)), closes [#82](#82) * Update manifest.json to allow rikaikun to work in srcdoc iframes. ([#411](#411)) ([093824b](093824b)), closes [#410](#410)
melink14
pushed a commit
that referenced
this pull request
May 11, 2021
## [1.1.0](v1.0.0...v1.1.0) (2021-05-11) ### Features * **dict:** Update dictionaries ([#451](#451)) ([97e6306](97e6306)) * **dict:** Update dictionaries to latest versions. ([#469](#469)) ([96a6032](96a6032)) ### Bug Fixes * Change manifest.json description to be more descriptive. ([#268](#268)) ([5fb116c](5fb116c)), closes [#245](#245) * Falsy setting values now correctly initialize. ([#408](#408)) ([327eecd](327eecd)), closes [#346](#346) * Migrate `onSelectionChanged` to `onActivated` ([#461](#461)) ([d8a0a9d](d8a0a9d)), closes [#153](#153) * Remove unneeded tabs permission from manifest. ([#266](#266)) ([d529e62](d529e62)), closes [#152](#152) * Reset badge text to empty on extension startup ([#462](#462)) ([b4afd3f](b4afd3f)), closes [#82](#82) * Update manifest.json to allow rikaikun to work in srcdoc iframes. ([#411](#411)) ([093824b](093824b)), closes [#410](#410)
melink14
pushed a commit
that referenced
this pull request
May 11, 2021
## [1.1.0](v1.0.0...v1.1.0) (2021-05-11) ### Features * **dict:** Update dictionaries ([#451](#451)) ([97e6306](97e6306)) * **dict:** Update dictionaries to latest versions. ([#469](#469)) ([96a6032](96a6032)) ### Bug Fixes * **manifest:** Edit the manifest description to fit under the character limit ([de5a21a](de5a21a)) * Change manifest.json description to be more descriptive. ([#268](#268)) ([5fb116c](5fb116c)), closes [#245](#245) * Falsy setting values now correctly initialize. ([#408](#408)) ([327eecd](327eecd)), closes [#346](#346) * Migrate `onSelectionChanged` to `onActivated` ([#461](#461)) ([d8a0a9d](d8a0a9d)), closes [#153](#153) * Remove unneeded tabs permission from manifest. ([#266](#266)) ([d529e62](d529e62)), closes [#152](#152) * Reset badge text to empty on extension startup ([#462](#462)) ([b4afd3f](b4afd3f)), closes [#82](#82) * Update manifest.json to allow rikaikun to work in srcdoc iframes. ([#411](#411)) ([093824b](093824b)), closes [#410](#410)
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documented here: https://developer.chrome.com/docs/extensions/mv3/content_scripts/ but that page doesn't mention srcdoc. Essentially srcdoc is a way to inject html into an iframe and as such it doesn't have a
srcattribute. In this case, chrome treats thesrcattribute asabout:blankwhich means without this option these types of frames won't have rikaikun injected into them.This stackoverflow is a great overview and also implies that the documentation used to be better:
https://stackoverflow.com/questions/41408936/can-anyone-explain-that-what-is-the-use-of-match-about-blank-in-chrome-extensi
Inspired by birchill/10ten-ja-reader@946b3aa
Fixes #410