feat(popup): Explicilty sets rikaikun to horizontal writing mode #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids inheriting veritcal text styles from host page when they're overly broad. Long term, shadow dom should help, and we should also make a popup position that works well for vertical text. Fixes #613
melink14
deleted the
melink14/issue613/FR-Explicilty-set-rikaikun-to-horizontal-writing-mode-to-avoid-inheriting-veritcal-text-styles-from-host-page
branch
melink14
pushed a commit
that referenced
this pull request
Jul 20, 2021
## [2.1.0](v2.0.1...v2.1.0) (2021-07-20) ### Features * **css:** Move popup themes into a single file using CSS variables ([#623](#623)) ([75241b5](75241b5)), closes [#222](#222) * **popup:** Explicilty sets rikaikun to horizontal writing mode ([#624](#624)) ([5fae815](5fae815)), closes [#613](#613) * Set `offline_enabled` to true in extension manifest ([#612](#612)) ([202aeac](202aeac)), closes [#429](#429) ### Bug Fixes * **dict:** Update dictionaries to latest versions. ([#620](#620)) ([9a67cb1](9a67cb1))
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids inheriting veritcal text styles from host page when they're overly broad.
Long term, shadow dom should help, and we should also make a popup position that works well for vertical text.
Fixes #613