-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Banding: rounding error, not slit issue? #405
Comments
If the clouds don't roll in, I'll try to recreate the effect today. |
I'm curious to see if you find out something. Both JSol'Ex and INTI (as far as I understood) use linear interpolation for reconstruction, so there shouldn't be rounding errors causing this 🤔 |
That's a good hint. A bilinear interpolation might be better to handle this. |
how comfortable are you with the idea of building JSol'Ex from a branch? |
at the moment, not much, as there are about |
Shouldn't involve much more than:
(if using windows that would be and give the potential fix a try. If you don't feel comfortable I could merge the PR and rollback if it doesn't help. |
Thank you, I'll try. |
(you may have to also set the |
Just reading the source code at the moment. This sure looks like something that "bridges" together values that, in a way, I think, would require something more like a point spread function to correct for the spectral line being divided up onto multiple pixels, and the surrounding "lines" bleeding into the pixel shift of interest. |
No, this is not it. It should be this guy
|
Thinking aloud: I think a point spread function is needed, as the bending smears the spectral line info into multiple pixels, and averaging them is in fact averaging values that are already an average of the spectral line and the surrounding continuum |
Well this is what the (optional) deconvolution is correcting. Taking a PSF into consideration during reconstruction is IMHO way too complicated. |
Still thinking aloud. A local slope should give the amount by which to perform a vertical-only deconvolution. In fact I think this is a good way to show what's happening with the spectral line, when it gets projected onto the sensor: it mixes up with the surrounding continuum. The phenomenon is aggravated by taking, again, into account, the adjacent pixels, while interpolating when locating the pixelshift. The error is masked when the line is wide enough and the curve is small enough -- or considered slit-caused banding when in fact it is not. |
Update, using version 2.7.1 dev. I am fairly confident my sodium raws are as decent as they can get, I had very good seeing today. I have the He from right next to it, and the Fe nearby, and they look fine. How do we get from the edge detection image with no polar caps and no severe banding, to the disk 0 (not the auto stretch, the disk zero) containing those severe bands and the polar-caps? While one may argue the polar caps here are indeed on the Sun, in the Sodium line as a feature, for they don't show up on the Fe image (line profile difference), I'd argue the banding is pure artifact from how the pixels are read out of the ser video via the polynomial. A very different line profile of the Na and the Fe could be the culprit for the polar caps. The line profile idea: for different spectral lines and for the same spectral line but different positions on the Sun (near the edge or limb central), as a concept. I have tens of gigabytes of raw ser videos of you feel like looking into it. For now, I obviously didn't go into editing your source code, shame on me. |
Using my Sodium images, I extracted two adjacent pixel offsets, separated by 0.5 pixels. The result is a reversal of the banding as shown in the pictures. Hence, my working hypothesis regarding both INTI and JSol'Ex is that at least some of the banding is a result not of the slit but of the disk-to-pixel mapping, falling sometimes towards the edge of the spectral line. This issue may then be exacerbated as the mu angle (together with the bending of the line's projection) increases. It could also be a camera readout issue, as the pixel shifts traverse camera scanlines at different x coordinates.
From M1p0LS and M1p5LS we have the following two frames, which shows the banding "blinking" ie getting reversed:
The text was updated successfully, but these errors were encountered: