Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make License mandatory for plugins submitted to meltanohub #1302

Open
rawwar opened this issue May 8, 2023 · 8 comments
Open

feat: Make License mandatory for plugins submitted to meltanohub #1302

rawwar opened this issue May 8, 2023 · 8 comments
Assignees

Comments

@rawwar
Copy link
Contributor

rawwar commented May 8, 2023

reference discussion link: https://meltano.slack.com/archives/C024T93P0AJ/p1683318763082389

Reason: This can help from using sources which have restrictive licenses. Make better informed choices when choosing a plugin

@pnadolny13
Copy link
Contributor

@rawwar thanks for logging this! I also created #1307 to document these standards and what to do with existing plugins that dont meet the standard.

@edgarrmondragon
Copy link
Collaborator

edgarrmondragon commented May 9, 2023

https://spdx.org/licenses/ is a good resource to get a list of valid license IDs

@rawwar
Copy link
Contributor Author

rawwar commented May 9, 2023

Also, all the ones that are currently default.. if they don't have a license.. we should probably remove them as default. And also include a note about missing license.. if anyone's trying to download them.

I'm proposing that because, licenses are probably the first thing orgs look at when using them. So, I think its important we highlight that.

@tayloramurphy
Copy link
Collaborator

@pnadolny13 per @rawwar's comment, do you know which plugins are default that don't have a license? I would agree that the default variant should have a license, especially if there are multiple variants available.

@pnadolny13
Copy link
Contributor

@tayloramurphy it actually looks like a fair amount of them dont have a license including some on MeltanoLabs so I created MeltanoLabs/Meta#46. I also would love to see meltano/sdk#235 get implemented with a default, some users just simply forget about a license.

@edgarrmondragon
Copy link
Collaborator

@pnadolny13 see meltano/sdk#1709

@rawwar
Copy link
Contributor Author

rawwar commented Jun 4, 2023

Just wondering, is it ok to update meltanohub repo's Github actions' with a task to checkout the repo and check if the license file exists? and if not.. fail it?

@pnadolny13
Copy link
Contributor

@rawwar I think thats a great idea! It can be added as another CI workflow https://github.com/meltano/hub/tree/main/.github/workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants