-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make License mandatory for plugins submitted to meltanohub #1302
Comments
https://spdx.org/licenses/ is a good resource to get a list of valid license IDs |
Also, all the ones that are currently default.. if they don't have a license.. we should probably remove them as default. And also include a note about missing license.. if anyone's trying to download them. I'm proposing that because, licenses are probably the first thing orgs look at when using them. So, I think its important we highlight that. |
@pnadolny13 per @rawwar's comment, do you know which plugins are default that don't have a license? I would agree that the default variant should have a license, especially if there are multiple variants available. |
@tayloramurphy it actually looks like a fair amount of them dont have a license including some on MeltanoLabs so I created MeltanoLabs/Meta#46. I also would love to see meltano/sdk#235 get implemented with a default, some users just simply forget about a license. |
Just wondering, is it ok to update meltanohub repo's Github actions' with a task to checkout the repo and check if the license file exists? and if not.. fail it? |
@rawwar I think thats a great idea! It can be added as another CI workflow https://github.com/meltano/hub/tree/main/.github/workflows. |
reference discussion link: https://meltano.slack.com/archives/C024T93P0AJ/p1683318763082389
Reason: This can help from using sources which have restrictive licenses. Make better informed choices when choosing a plugin
The text was updated successfully, but these errors were encountered: