-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Plugin: tap-playstore #1688
Comments
@haleemur thanks for the issue and for working on the tap! How do we think we should list this relative to the existing tap-google-play variants? https://hub.meltano.com/extractors/tap-google-play. They have overlap with the reviews stream in both but tap-google-play looks to scrape the data vs tap-playstore that gets it from the GCS exports. |
@pnadolny13 I hadn't thought of that yet actually. I guess I could update the documentation on haleemur/tap-playstore further to clarify that this pulls in the google console exports. The first line of the README currently states
If you have suggestions for specific language that might help a meltano-hub user decide which is the right variant for them, please let me know and I can update the description. |
@haleemur I'm leaning towards listing them as 2 separate plugins. They have different use cases as the scraper scrapes reviews without credentials whereas the GCS export needs credentials and includes sales data that will never be available to the scraper. Maybe by updating the existing plugin to "Google Play (Reviews Scraper)" and this one can be "Google Play (GCS Export)" or something like that, open to other naming suggestions. |
@pnadolny13 I like your relabeling suggestion |
What is the plugin type?
extractor
Repository URL
https://github.com/haleemur/tap-playstore
Extension Repository URL
No response
Description
Google Play Store is a marketplace for Android Apps
Domain URL
https://github.com/haleemur/tap-playstore
Logo Image
Any other notes?
No response
The text was updated successfully, but these errors were encountered: