Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Added docs for --cwd CLI option #8156

Merged
merged 3 commits into from
Sep 18, 2023
Merged

docs: Added docs for --cwd CLI option #8156

merged 3 commits into from
Sep 18, 2023

Conversation

XshubhamX
Copy link
Contributor

Additions:

  • Added the doc for --cwd command option and added one example usage inside the settings doc file

cc @edgarrmondragon

@netlify
Copy link

netlify bot commented Sep 17, 2023 •
edited
Loading

👷 Deploy request for meltano pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 739a541

@XshubhamX XshubhamX changed the title Added docs for --cwd CLI option docs: Added docs for --cwd CLI option Sep 17, 2023
WillDaSilva
WillDaSilva reviewed Sep 17, 2023
View reviewed changes
Copy link
Member

@WillDaSilva WillDaSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @XshubhamX! I've left a few suggestions, and would be happy to approve & merge this PR once they've been addressed.

docs/docs/reference/settings.md Outdated Show resolved Hide resolved
docs/docs/reference/command-line-interface.md Outdated Show resolved Hide resolved
docs/docs/reference/command-line-interface.md Outdated Show resolved Hide resolved
docs/docs/reference/command-line-interface.md Outdated Show resolved Hide resolved
@XshubhamX
Doc fixes
f3208ee 
Updated global config desc. and --cwd option's doc changes
@XshubhamX
Copy link
Contributor Author

@WillDaSilva updated the PR, please check.

WillDaSilva
WillDaSilva reviewed Sep 18, 2023
View reviewed changes
docs/docs/reference/settings.md Outdated Show resolved Hide resolved
docs/docs/reference/settings.md Outdated Show resolved Hide resolved
docs/docs/reference/settings.md Outdated Show resolved Hide resolved
docs/docs/reference/command-line-interface.md Outdated Show resolved Hide resolved
WillDaSilva
WillDaSilva approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@WillDaSilva WillDaSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @XshubhamX!

@WillDaSilva WillDaSilva added this pull request to the merge queue Sep 18, 2023
Merged via the queue into meltano:main with commit 8e33845 Sep 18, 2023
2 checks passed
@XshubhamX XshubhamX mentioned this pull request Sep 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillDaSilva WillDaSilva WillDaSilva approved these changes

@sbalnojan sbalnojan Awaiting requested review from sbalnojan

@tayloramurphy tayloramurphy Awaiting requested review from tayloramurphy tayloramurphy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XshubhamX @WillDaSilva