fix(templates): add environment support to the cookie cutter for meltano.yml
#1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnadolny13
requested review from
edgarrmondragon,
cjohnhanson and
aaronsteers
as code owners
WillDaSilva
requested changes
Oct 20, 2022
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1093 +/- ##
=======================================
Coverage 83.60% 83.60%
=======================================
Files 40 40
Lines 3805 3805
Branches 640 640
=======================================
Hits 3181 3181
Misses 464 464
Partials 160 160 ☔ View full report in Codecov by Sentry. |
aaronsteers
changed the title
meltano.yml
aaronsteers
changed the title
meltano.ymlmeltano.yml
|
@WillDaSilva @aaronsteers I updated based on your feedback and added to the target cookiecutter too! I also just noticed that the target meltano.yml had capabilities that only relate to extractors. I replaced them with what I think are the default target capabilities. |
pnadolny13
changed the title
meltano.ymlmeltano.yml
WillDaSilva
approved these changes
Oct 20, 2022
edgarrmondragon
requested changes
Oct 20, 2022
edgarrmondragon
approved these changes
Oct 20, 2022
edgarrmondragon
changed the title
meltano.ymlmeltano.yml
edgarrmondragon
changed the title
meltano.ymlmeltano.yml
|
@pnadolny13 This looks good. Just a last ping to @aaronsteers to check the PR title. |
Looks good! Thanks! |
aaronsteers
approved these changes
Oct 20, 2022
This was referenced Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1092
Related to slack thread https://meltano.slack.com/archives/C01TCRBBJD7/p1666232552939149
📚 Documentation preview 📚: https://meltano-sdk--1093.org.readthedocs.build/en/1093/