feat: Explicitly support URL params in string form #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1623 +/- ##
=======================================
Coverage 86.41% 86.41%
=======================================
Files 58 58
Lines 4761 4761
Branches 798 798
=======================================
Hits 4114 4114
Misses 456 456
Partials 191 191
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
edgarrmondragon
commented
Apr 19, 2023
edgarrmondragon
commented
Apr 19, 2023
kgpayne
approved these changes
Apr 25, 2023
There was a problem hiding this comment.
Its not obvious from the requests docs but I had a look at the source and verified strings are supported as params 🙌 This is very neat @edgarrmondragon 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://meltano.slack.com/archives/C021CVD2E21/p1678910870929319
Updated docs: https://meltano-sdk--1623.org.readthedocs.build/en/1623/classes/singer_sdk.RESTStream.html#singer_sdk.RESTStream.get_url_params
📚 Documentation preview 📚: https://meltano-sdk--1623.org.readthedocs.build/en/1623/