Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(templates): Use Ruff to lint projects generated with Cookiecutter templates #1648

Merged

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Apr 28, 2023

@edgarrmondragon edgarrmondragon linked an issue Apr 28, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #1648 (8972966) into main (3609320) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1648   +/-   ##
=======================================
  Coverage   85.05%   85.05%           
=======================================
  Files          58       58           
  Lines        4845     4845           
  Branches      805      805           
=======================================
  Hits         4121     4121           
  Misses        526      526           
  Partials      198      198           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon force-pushed the 1596-migrate-cookiecutters-to-ruff-for-linting branch 2 times, most recently from c4c6e8f to 6fc7584 Compare April 28, 2023 00:47
@edgarrmondragon edgarrmondragon force-pushed the 1596-migrate-cookiecutters-to-ruff-for-linting branch from 6fc7584 to ee1d664 Compare April 28, 2023 01:49
@edgarrmondragon edgarrmondragon marked this pull request as ready for review April 28, 2023 01:55
Copy link
Member

@WillDaSilva WillDaSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I found one issue where a fresh SQL target would fail a Ruff check, but I pushed a commit to fix it.

This is a significant reduction of the number of dev dependencies each SDK-based tap/target will have, which is great for avoiding dependency hell.

I noticed that the Ruff target version is py37. That makes sense for now, but we'll want to update that to py38 on 2023-06-27 per https://devguide.python.org/versions/

@edgarrmondragon
Copy link
Collaborator Author

Looks good to me. I found one issue where a fresh SQL target would fail a Ruff check, but I pushed a commit to fix it.

This is a significant reduction of the number of dev dependencies each SDK-based tap/target will have, which is great for avoiding dependency hell.

I noticed that the Ruff target version is py37. That makes sense for now, but we'll want to update that to py38 on 2023-06-27 per https://devguide.python.org/versions/

thanks @WillDaSilva, I added a test for that missing case to make sure both "per record" and SQL targets pass Ruff checks.

@edgarrmondragon edgarrmondragon changed the title feat(templates): Use Ruff to lint Cookiecutter templates feat(templates): Use Ruff to lint projects generated with Cookiecutter templates May 2, 2023
@edgarrmondragon edgarrmondragon merged commit dc307b6 into main May 2, 2023
@edgarrmondragon edgarrmondragon deleted the 1596-migrate-cookiecutters-to-ruff-for-linting branch May 2, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate cookiecutters to Ruff for linting
2 participants