-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(templates): Use Ruff to lint projects generated with Cookiecutter templates #1648
feat(templates): Use Ruff to lint projects generated with Cookiecutter templates #1648
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1648 +/- ##
=======================================
Coverage 85.05% 85.05%
=======================================
Files 58 58
Lines 4845 4845
Branches 805 805
=======================================
Hits 4121 4121
Misses 526 526
Partials 198 198 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
c4c6e8f
to
6fc7584
Compare
6fc7584
to
ee1d664
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I found one issue where a fresh SQL target would fail a Ruff check, but I pushed a commit to fix it.
This is a significant reduction of the number of dev dependencies each SDK-based tap/target will have, which is great for avoiding dependency hell.
I noticed that the Ruff target version is py37
. That makes sense for now, but we'll want to update that to py38
on 2023-06-27 per https://devguide.python.org/versions/
thanks @WillDaSilva, I added a test for that missing case to make sure both "per record" and SQL targets pass Ruff checks. |
📚 Documentation preview 📚: https://meltano-sdk--1648.org.readthedocs.build/en/1648/