-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Fix invalid JSON in Stream Maps page and add meltano.yml
tabs
#1756
Conversation
- Also removed trailing commas in list/dict objects to make the JSON syntactically valid - Removed all comments from JSON and added to meltano.yml tab
Codecov Report
@@ Coverage Diff @@
## main #1756 +/- ##
=======================================
Coverage 86.12% 86.12%
=======================================
Files 59 59
Lines 4944 4944
Branches 809 809
=======================================
Hits 4258 4258
Misses 485 485
Partials 201 201 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Quick link to the changed page: |
Just shifted the meltano.yml tabs first, makes more sense as the tabs with the comments are displayed first - the JSON without comments can be viewed optionally |
@mjsqu these tabs look so good, thanks for the PR! The only thing I'm still unclear on is null handling in the meltano.yml files. I know theres an option to include |
meltano.yml
tabs
@pnadolny13 good catch! It's probably just better to use |
Thanks @mjsqu! I've suggested some changes. |
Co-authored-by: Edgar R. M. <edgarrm358@gmail.com>
Co-authored-by: Edgar R. M. <edgarrm358@gmail.com>
Uh - I thought a poetry lock run was suggested, but I can't find that comment now 😆 |
Lol, it's here: #1756 (comment) Oh, bummer. The tabs plugin requires Python 3.8+ 😭. That means #1659 is a blocker for this. |
On second thought, RTD uses Python 3.11 to build the docs so using an env marker for the dependency should be fine. |
Resolves #797
📚 Documentation preview 📚: https://meltano-sdk--1756.org.readthedocs.build/en/1756/