Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add descriptions for batch_config properties #1771

Merged
merged 1 commit into from
Jun 19, 2023
Merged

fix: Add descriptions for batch_config properties #1771

merged 1 commit into from
Jun 19, 2023

Conversation

pnadolny13
Copy link
Contributor

@pnadolny13 pnadolny13 commented Jun 19, 2023 •
edited by github-actions bot
Loading

@pnadolny13 pnadolny13 changed the title add descriptions for batch_config properties chore: add descriptions for batch_config properties Jun 19, 2023
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #1771 (759a614) into main (b498042) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1771   +/-   ##
=======================================
  Coverage   85.61%   85.61%           
=======================================
  Files          59       59           
  Lines        4937     4937           
  Branches      809      809           
=======================================
  Hits         4227     4227           
  Misses        507      507           
  Partials      203      203
Impacted Files Coverage Δ
singer_sdk/helpers/capabilities.py 91.66% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon changed the title chore: add descriptions for batch_config properties fix: Add descriptions for batch_config properties Jun 19, 2023
edgarrmondragon
edgarrmondragon approved these changes Jun 19, 2023
View reviewed changes
Copy link
Collaborator

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pnadolny13!

@edgarrmondragon edgarrmondragon merged commit e877215 into main Jun 19, 2023
@edgarrmondragon edgarrmondragon deleted the add_batch_config_descriptions branch June 19, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgarrmondragon edgarrmondragon edgarrmondragon approved these changes

@kgpayne kgpayne Awaiting requested review from kgpayne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pnadolny13 @edgarrmondragon