Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(targets): Deserialize floats as decimal.Decimal #1809

Merged
merged 3 commits into from
Jul 6, 2023
Merged

fix(targets): Deserialize floats as decimal.Decimal #1809

merged 3 commits into from
Jul 6, 2023

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jul 5, 2023 •
edited
Loading

Closes #344

📚 Documentation preview 📚: https://meltano-sdk--1809.org.readthedocs.build/en/1809/

@edgarrmondragon edgarrmondragon linked an issue Jul 5, 2023 that may be closed by this pull request
JSON decimal values should be parsed as Python decimal.Decimal in targets when reading Singer messages #344
Closed
@edgarrmondragon edgarrmondragon force-pushed the 344-json-decimal-values-should-be-parsed-as-python-decimaldecimal-in-targets-when-reading-singer-messages branch from f1de868 to f3fd68f Compare July 5, 2023 16:54
@codecov
Copy link

codecov bot commented Jul 5, 2023 •
edited
Loading

Codecov Report

Merging #1809 (acc7320) into main (77c3f90) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1809      +/-   ##
==========================================
+ Coverage   86.38%   86.44%   +0.06%     
==========================================
  Files          59       59              
  Lines        4971     4974       +3     
  Branches      813      813              
==========================================
+ Hits         4294     4300       +6     
+ Misses        479      476       -3     
  Partials      198      198
Impacted Files Coverage Δ
singer_sdk/io_base.py 87.27% <100.00%> (+6.50%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon
Copy link
Collaborator Author

@kgpayne can you give this PR a 👀 when you got a minute?

pnadolny13
pnadolny13 approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@pnadolny13 pnadolny13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edgarrmondragon LGTM!

@edgarrmondragon edgarrmondragon merged commit 4cbf8a8 into main Jul 6, 2023
@edgarrmondragon edgarrmondragon deleted the 344-json-decimal-values-should-be-parsed-as-python-decimaldecimal-in-targets-when-reading-singer-messages branch July 6, 2023 19:30
@pnadolny13 pnadolny13 mentioned this pull request Jul 10, 2023
Closed
@edgarrmondragon edgarrmondragon mentioned this pull request Aug 7, 2023
Closed
1 task
@pnadolny13 pnadolny13 mentioned this pull request Nov 3, 2023
Open
@edgarrmondragon edgarrmondragon mentioned this pull request Nov 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnadolny13 pnadolny13 pnadolny13 approved these changes

@kgpayne kgpayne Awaiting requested review from kgpayne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON decimal values should be parsed as Python decimal.Decimal in targets when reading Singer messages
2 participants
@edgarrmondragon @pnadolny13