Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Serialization of decimal.Decimal #1826

Merged

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jul 10, 2023

Closes #1825


📚 Documentation preview 📚: https://meltano-sdk--1826.org.readthedocs.build/en/1826/

@edgarrmondragon edgarrmondragon linked an issue Jul 10, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #1826 (b744677) into main (5a1190a) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1826      +/-   ##
==========================================
+ Coverage   86.42%   86.46%   +0.04%     
==========================================
  Files          59       59              
  Lines        4996     4996              
  Branches      816      816              
==========================================
+ Hits         4318     4320       +2     
  Misses        479      479              
+ Partials      199      197       -2     
Impacted Files Coverage Δ
singer_sdk/batch.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon marked this pull request as ready for review July 10, 2023 16:57
@edgarrmondragon edgarrmondragon merged commit 8fb30f3 into main Jul 10, 2023
@edgarrmondragon edgarrmondragon deleted the 1825-bug-object-of-type-decimal-is-not-json-serializable branch July 10, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Object of type Decimal is not JSON serializable
2 participants