fix(targets): Check against the unconformed key properties when validating record keys #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ating record keys
1 task
1 task
Codecov Report
@@ Coverage Diff @@
## main #1853 +/- ##
=======================================
Coverage 86.56% 86.56%
=======================================
Files 59 59
Lines 5000 5000
Branches 811 811
=======================================
Hits 4328 4328
Misses 476 476
Partials 196 196
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@edgarrmondragon, wow fixed with a single |
|
This seems to work in target-snowflake (MeltanoLabs/target-snowflake#94) |
|
I think we have enough validation that the fix works, so I'll go ahead and merge it |
edgarrmondragon
deleted the
1819-bug-incorrectly-raising-missingkeypropertieserror-when-column-name-conformed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
MissingKeyPropertiesErrorwhen column name conformed #1819cc @pnadolny13
📚 Documentation preview 📚: https://meltano-sdk--1853.org.readthedocs.build/en/1853/