Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use importlib.resources instead of __file__ to retrieve sample Singer output files #1877

Merged
merged 3 commits into from
Jul 27, 2023

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jul 26, 2023

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #1877 (cf94d10) into main (6576f52) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1877   +/-   ##
=======================================
  Coverage   86.72%   86.73%           
=======================================
  Files          59       59           
  Lines        5018     5019    +1     
  Branches      814      814           
=======================================
+ Hits         4352     4353    +1     
  Misses        470      470           
  Partials      196      196           
Files Changed Coverage Δ
singer_sdk/testing/templates.py 86.66% <100.00%> (+0.14%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon
Copy link
Collaborator Author

Internal refactor, only touches the testing framework.

@edgarrmondragon edgarrmondragon merged commit b0a8621 into main Jul 27, 2023
25 checks passed
@edgarrmondragon edgarrmondragon deleted the refactor/singer-samples-importlib-resources branch July 27, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant