Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Append batch config if target supports the batch capability #1880

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jul 27, 2023

Closes #1879


📚 Documentation preview 📚: https://meltano-sdk--1880.org.readthedocs.build/en/1880/

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #1880 (33dbe54) into main (759c77b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1880      +/-   ##
==========================================
+ Coverage   86.89%   86.92%   +0.02%     
==========================================
  Files          59       59              
  Lines        5060     5071      +11     
  Branches      819      822       +3     
==========================================
+ Hits         4397     4408      +11     
  Misses        466      466              
  Partials      197      197              
Files Changed Coverage Δ
singer_sdk/target_base.py 92.27% <100.00%> (+0.34%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon marked this pull request as ready for review July 27, 2023 19:25
@edgarrmondragon edgarrmondragon requested review from pnadolny13 and removed request for kgpayne July 27, 2023 19:25
@edgarrmondragon edgarrmondragon enabled auto-merge (squash) July 27, 2023 20:49
…-to-targets-own-config-schema-if-the-target-supports-the-batch-capability
@edgarrmondragon edgarrmondragon merged commit c3a8f90 into main Jul 31, 2023
25 checks passed
@edgarrmondragon edgarrmondragon deleted the 1879-bug-batch-config-schema-is-not-appended-to-targets-own-config-schema-if-the-target-supports-the-batch-capability branch July 31, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants