Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a mapper cookiecutter template #1892

Merged
merged 8 commits into from
Aug 3, 2023
Merged

Conversation

pnadolny13
Copy link
Contributor

@pnadolny13 pnadolny13 commented Aug 2, 2023

Closes #1645

I was trying to build a mapper related to https://github.com/meltano/internal-data/issues/131 and noticed it was pretty difficult and manual. Creating at least a draft of this was going to save me time vs manually copy/pasting an existing mapper.

I wasnt sure what the cookiecutter.test.yml was actually doing, it looks like theyre outdated (e.g. include_cicd_sample_template vs what I think is now called include_ci_files). Let me know if I should put that back in.

I tried to update everything I could find but will manually test that it works as expected.

NOTE: the one thing thats not incorporated in here from map-gpt-embeddings is the time_extracted parsing, see https://github.com/MeltanoLabs/map-gpt-embeddings/blob/2de64bb8d5b42ffdb3b93420efd1d2bb06141d7b/map_gpt_embeddings/sdk_fixes/messages.py#L13. I used this cookiecutter and did see that error pop up but I had a hard time reproducing it. I will create a separate bug issue if I'm able to reproduce.


📚 Documentation preview 📚: https://meltano-sdk--1892.org.readthedocs.build/en/1892/

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #1892 (f0918cc) into main (6ce7eab) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1892   +/-   ##
=======================================
  Coverage   86.93%   86.93%           
=======================================
  Files          59       59           
  Lines        5073     5073           
  Branches      822      822           
=======================================
  Hits         4410     4410           
  Misses        466      466           
  Partials      197      197           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pnadolny13 pnadolny13 marked this pull request as ready for review August 2, 2023 21:00
@edgarrmondragon edgarrmondragon changed the title feat: Mapper cookiecutter feat: Add a mapper cookiecutter template Aug 3, 2023
Copy link
Collaborator

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @pnadolny13.

@edgarrmondragon edgarrmondragon merged commit 65d9dba into main Aug 3, 2023
26 checks passed
@edgarrmondragon edgarrmondragon deleted the mapper_cookiecutter branch August 3, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add cookiecutter template for mappers
2 participants