fix: Ensure SQL streams are sorted when a replication key is set #1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarrmondragon
changed the title
edgarrmondragon
force-pushed
the
1950-bug-is_sorted-should-be-true-for-sqlstream-with-replication-keys
branch
from
74cd6b0
to
00798e0
Compare
|
SQLAlchemy 1.* tests are failing because inspected columns have a different order, so the SCHEMA messages, and thus the snapshots, are different. EDIT: Not using snapshots anymore because of this 🤷♂️ |
edgarrmondragon
force-pushed
the
1950-bug-is_sorted-should-be-true-for-sqlstream-with-replication-keys
branch
from
8ee00ec
to
54e97b2
Compare
Codecov Report
@@ Coverage Diff @@
## main #1951 +/- ##
==========================================
- Coverage 87.04% 87.01% -0.04%
==========================================
Files 59 59
Lines 5109 5112 +3
Branches 827 827
==========================================
+ Hits 4447 4448 +1
- Misses 465 468 +3
+ Partials 197 196 -1
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…eam-with-replication-keys
edgarrmondragon
commented
Sep 12, 2023
pnadolny13
approved these changes
Sep 13, 2023
kgpayne
approved these changes
Sep 13, 2023
…eam-with-replication-keys
edgarrmondragon
deleted the
1950-bug-is_sorted-should-be-true-for-sqlstream-with-replication-keys
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://meltano-sdk--1951.org.readthedocs.build/en/1951/