Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Break up TapTestClassFactory._annotate_test_class into simpler methods #2056

Merged

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Nov 18, 2023

Copy link

codspeed-hq bot commented Nov 18, 2023

CodSpeed Performance Report

Merging #2056 will not alter performance

Comparing refactor/TapTestClassFactory._annotate_test_class (88ea277) with main (4cc52db)

Summary

✅ 3 untouched benchmarks

@edgarrmondragon edgarrmondragon force-pushed the refactor/TapTestClassFactory._annotate_test_class branch 3 times, most recently from 2b5f8bd to f74dcea Compare November 18, 2023 01:13
Copy link

codecov bot commented Nov 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4cc52db) 87.46% compared to head (88ea277) 87.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2056      +/-   ##
==========================================
+ Coverage   87.46%   87.48%   +0.02%     
==========================================
  Files          58       58              
  Lines        4867     4875       +8     
  Branches      993      993              
==========================================
+ Hits         4257     4265       +8     
  Misses        429      429              
  Partials      181      181              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon
Copy link
Collaborator Author

edgarrmondragon commented Nov 18, 2023

Seems like I'm refactoring untested code 😅

@edgarrmondragon edgarrmondragon force-pushed the refactor/TapTestClassFactory._annotate_test_class branch 8 times, most recently from 6884436 to 72e56aa Compare November 22, 2023 05:00
@edgarrmondragon edgarrmondragon force-pushed the refactor/TapTestClassFactory._annotate_test_class branch from 72e56aa to 88ea277 Compare November 22, 2023 05:07
@edgarrmondragon edgarrmondragon marked this pull request as ready for review November 22, 2023 05:17
@edgarrmondragon edgarrmondragon merged commit 513945e into main Nov 22, 2023
30 checks passed
@edgarrmondragon edgarrmondragon deleted the refactor/TapTestClassFactory._annotate_test_class branch November 22, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant