Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Allow loading stream schemas from importlib.resources.abc.Traversable types #2130

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jan 2, 2024

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/allow-loading-importlib-traversable-types branch from 16d8a17 to 37c47fa Compare January 2, 2024 16:55
Copy link

codspeed-hq bot commented Jan 2, 2024

CodSpeed Performance Report

Merging #2130 will not alter performance

Comparing edgarrmondragon/refactor/allow-loading-importlib-traversable-types (7b172b0) with main (7ea2ec4)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (970c2f9) 87.82% compared to head (7b172b0) 87.82%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2130      +/-   ##
==========================================
- Coverage   87.82%   87.82%   -0.01%     
==========================================
  Files          60       60              
  Lines        4946     4944       -2     
  Branches     1007     1007              
==========================================
- Hits         4344     4342       -2     
  Misses        424      424              
  Partials      178      178              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/allow-loading-importlib-traversable-types branch 7 times, most recently from 5d642ea to 2dd51d1 Compare January 3, 2024 15:55
@edgarrmondragon edgarrmondragon marked this pull request as ready for review January 3, 2024 15:58
@edgarrmondragon edgarrmondragon marked this pull request as draft January 3, 2024 15:58
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/allow-loading-importlib-traversable-types branch 3 times, most recently from b25f179 to 6128274 Compare January 8, 2024 22:39
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/allow-loading-importlib-traversable-types branch from 6128274 to 7b172b0 Compare January 8, 2024 22:48
@edgarrmondragon edgarrmondragon marked this pull request as ready for review January 8, 2024 23:49
@edgarrmondragon edgarrmondragon requested a review from a team as a code owner January 8, 2024 23:49
@edgarrmondragon edgarrmondragon merged commit 873ea36 into main Jan 8, 2024
34 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/refactor/allow-loading-importlib-traversable-types branch January 8, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant