Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(taps): Fix serialization of arbitrary objects (e.g. ObjectId from mongoDB) during flattening #2203

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

dgawlowsky
Copy link
Contributor

@dgawlowsky dgawlowsky commented Jan 30, 2024

Copy link

codspeed-hq bot commented Jan 30, 2024

CodSpeed Performance Report

Merging #2203 will not alter performance

Comparing dgawlowsky:patch-1 (fd9e29b) with main (fa888be)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fa888be) 88.46% compared to head (fd9e29b) 88.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2203   +/-   ##
=======================================
  Coverage   88.46%   88.46%           
=======================================
  Files          54       54           
  Lines        4716     4716           
  Branches      917      917           
=======================================
  Hits         4172     4172           
  Misses        383      383           
  Partials      161      161           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon changed the title fix(taps): fix parsing ObjectId from mongoDB fix(taps): Fix serialization of arbitrary objects (e.g. ObjectId from mongoDB) during flattening Jan 31, 2024
@edgarrmondragon edgarrmondragon changed the title fix(taps): Fix serialization of arbitrary objects (e.g. ObjectId from mongoDB) during flattening fix(taps): Fix serialization of arbitrary objects (e.g. ObjectId from mongoDB) during flattening Jan 31, 2024
Copy link
Collaborator

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dgawlowsky!

@edgarrmondragon edgarrmondragon added this pull request to the merge queue Jan 31, 2024
Merged via the queue into meltano:main with commit 4a4fddb Jan 31, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: parsing ObjectId object from MongoDB in tap-mongodb
2 participants