Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Nested settings are now documented in the output of --about --format=markdown #2263

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Feb 22, 2024

Closes #1884


📚 Documentation preview 📚: https://meltano-sdk--2263.org.readthedocs.build/en/2263/

Copy link

codspeed-hq bot commented Feb 22, 2024

CodSpeed Performance Report

Merging #2263 will not alter performance

⚠️ No base runs were found

Falling back to comparing 1884-feat-display-nested-settings-in-the-output-of-about-format=markdown (870a500) with main (3e2c3d3)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.68%. Comparing base (597291c) to head (870a500).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2263      +/-   ##
==========================================
+ Coverage   88.67%   88.68%   +0.01%     
==========================================
  Files          54       54              
  Lines        4732     4738       +6     
  Branches      921      921              
==========================================
+ Hits         4196     4202       +6     
  Misses        374      374              
  Partials      162      162              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review February 22, 2024 23:58
@edgarrmondragon edgarrmondragon merged commit ae7614e into main Feb 23, 2024
32 checks passed
@edgarrmondragon edgarrmondragon deleted the 1884-feat-display-nested-settings-in-the-output-of-about-format=markdown branch February 23, 2024 15:38
edgarrmondragon added a commit that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Display nested settings in the output of --about --format=markdown
1 participant