Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Developers can now customize the default logging configuration for their taps/targets by adding default_logging.yml to their package #2432

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented May 17, 2024

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.42%. Comparing base (b566a5b) to head (b3aaa84).
Report is 140 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2432   +/-   ##
=======================================
  Coverage   89.41%   89.42%           
=======================================
  Files          58       58           
  Lines        4781     4783    +2     
  Branches      933      933           
=======================================
+ Hits         4275     4277    +2     
  Misses        353      353           
  Partials      153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented May 17, 2024

CodSpeed Performance Report

Merging #2432 will not alter performance

Comparing 1373-feature-allow-application-developers-to-customize-logging-configuration (b3aaa84) with main (b566a5b)

Summary

✅ 6 untouched benchmarks

@edgarrmondragon edgarrmondragon force-pushed the 1373-feature-allow-application-developers-to-customize-logging-configuration branch 2 times, most recently from 5c184c6 to d14cae1 Compare May 23, 2024 15:44
@edgarrmondragon edgarrmondragon force-pushed the 1373-feature-allow-application-developers-to-customize-logging-configuration branch from d14cae1 to ac3c46b Compare May 28, 2024 01:46
@edgarrmondragon edgarrmondragon force-pushed the 1373-feature-allow-application-developers-to-customize-logging-configuration branch from ac3c46b to 1ef08ba Compare July 4, 2024 03:24
@edgarrmondragon edgarrmondragon marked this pull request as ready for review July 4, 2024 03:25
@edgarrmondragon edgarrmondragon force-pushed the 1373-feature-allow-application-developers-to-customize-logging-configuration branch 2 times, most recently from e6663e8 to 204f594 Compare July 16, 2024 19:38
…for their taps/targets by overriding the `get_default_logging_config` method

Related:

* Closes #1373
@edgarrmondragon edgarrmondragon force-pushed the 1373-feature-allow-application-developers-to-customize-logging-configuration branch from 204f594 to 75012ea Compare July 16, 2024 22:13
@edgarrmondragon edgarrmondragon marked this pull request as draft July 17, 2024 23:50
@edgarrmondragon
Copy link
Collaborator Author

It might be better to expect the config file to be on a specific location within the package.

@edgarrmondragon edgarrmondragon changed the title feat: Developers can now customize the default logging configuration for their taps/targets by overriding the get_default_logging_config method feat: Developers can now customize the default logging configuration for their taps/targets by adding a default_logging.yml to their package Jul 18, 2024
@edgarrmondragon edgarrmondragon changed the title feat: Developers can now customize the default logging configuration for their taps/targets by adding a default_logging.yml to their package feat: Developers can now customize the default logging configuration for their taps/targets by adding default_logging.yml to their package Jul 18, 2024
@edgarrmondragon edgarrmondragon marked this pull request as ready for review July 18, 2024 00:31
@edgarrmondragon edgarrmondragon requested review from a team as code owners July 18, 2024 00:31
@edgarrmondragon edgarrmondragon merged commit fe5a01b into main Jul 18, 2024
32 of 33 checks passed
@edgarrmondragon edgarrmondragon deleted the 1373-feature-allow-application-developers-to-customize-logging-configuration branch July 18, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Allow application developers to customize logging configuration
2 participants