-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Developers can now customize the default logging configuration for their taps/targets by adding default_logging.yml
to their package
#2432
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2432 +/- ##
=======================================
Coverage 89.41% 89.42%
=======================================
Files 58 58
Lines 4781 4783 +2
Branches 933 933
=======================================
+ Hits 4275 4277 +2
Misses 353 353
Partials 153 153 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #2432 will not alter performanceComparing Summary
|
5c184c6
to
d14cae1
Compare
d14cae1
to
ac3c46b
Compare
ac3c46b
to
1ef08ba
Compare
e6663e8
to
204f594
Compare
…for their taps/targets by overriding the `get_default_logging_config` method Related: * Closes #1373
204f594
to
75012ea
Compare
…-customize-logging-configuration
It might be better to expect the config file to be on a specific location within the package. |
get_default_logging_config
methoddefault_logging.yml
to their package
default_logging.yml
to their packagedefault_logging.yml
to their package
Related:
📚 Documentation preview 📚: https://meltano-sdk--2432.org.readthedocs.build/en/2432/