Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(target): DDL for adding a column now uses a SQLAlchemy-compiled clause to apply proper quoting #2582

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

haleemur
Copy link
Contributor

@haleemur haleemur commented Aug 1, 2024

Description

call the compile method, specifying the sqlalchemy engine, this ensures that sqlalchemy is able to specify database specific object quoting.


📚 Documentation preview 📚: https://meltano-sdk--2582.org.readthedocs.build/en/2582/

Copy link

codspeed-hq bot commented Aug 1, 2024

CodSpeed Performance Report

Merging #2582 will not alter performance

Comparing haleemur:add-column-db-quoting (a48a3be) with main (cb163bf)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.47%. Comparing base (cb163bf) to head (a48a3be).
Report is 125 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2582   +/-   ##
=======================================
  Coverage   89.47%   89.47%           
=======================================
  Files          58       58           
  Lines        4799     4799           
  Branches      937      936    -1     
=======================================
  Hits         4294     4294           
  Misses        352      352           
  Partials      153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon changed the title compile create column clause with sqla engine to apply proper quoting fix: compile create column clause with sqla engine to apply proper quoting Aug 1, 2024
@edgarrmondragon edgarrmondragon self-assigned this Aug 1, 2024
@edgarrmondragon edgarrmondragon changed the title fix: compile create column clause with sqla engine to apply proper quoting fix(target): DDL for adding a column now uses a SQLAlchemy-compiled clause to apply proper quoting Aug 1, 2024
Copy link
Collaborator

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @haleemur!

@edgarrmondragon edgarrmondragon merged commit 7ccfb87 into meltano:main Aug 1, 2024
29 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants