-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(targets): Make sink assertion compatible with stream maps #2589
Conversation
CodSpeed Performance ReportMerging #2589 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2589 +/- ##
=======================================
Coverage 89.47% 89.47%
=======================================
Files 58 58
Lines 4798 4800 +2
Branches 936 937 +1
=======================================
+ Hits 4293 4295 +2
Misses 352 352
Partials 153 153 ☔ View full report in Codecov by Sentry. |
@JCotton1123 thanks for the PR! Can you expand on what problem this solves? The original code does smell like a bug, but I'd like to understand better what errors you're running into with the current implementation. |
I just added a bit more detail. Let me know if I can provide more. |
f07f11a
to
9521c82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @JCotton1123!
The change here is necessary to ensure the assertion utilizes the aliases stream name (vs the original stream name).
Given a stream_maps config with an
__alias__
configuration, see example below, a target will produce the following error:📚 Documentation preview 📚: https://meltano-sdk--2589.org.readthedocs.build/en/2589/