Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use context manager to read gzip batch files #2628

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Aug 26, 2024

Copy link

codspeed-hq bot commented Aug 26, 2024

CodSpeed Performance Report

Merging #2628 will not alter performance

Comparing edgarrmondragon/refactor/use-context-read-gzip (a2d6c55) with main (ddb922a)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.67%. Comparing base (ddb922a) to head (a2d6c55).

Files Patch % Lines
singer_sdk/sinks/core.py 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2628      +/-   ##
==========================================
- Coverage   89.71%   89.67%   -0.04%     
==========================================
  Files          58       58              
  Lines        4853     4854       +1     
  Branches      948      950       +2     
==========================================
- Hits         4354     4353       -1     
- Misses        349      350       +1     
- Partials      150      151       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon merged commit 2a3d3fa into main Aug 26, 2024
36 of 37 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/refactor/use-context-read-gzip branch August 26, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant