Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove dependency on pipelinewise-singer-python and move singer library code into singer_sdk._singerlib #979

Merged
merged 9 commits into from
Sep 23, 2022
Merged

refactor: Remove dependency on pipelinewise-singer-python and move singer library code into singer_sdk._singerlib #979

merged 9 commits into from
Sep 23, 2022

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Sep 17, 2022 •
edited by aaronsteers
Loading

Related issues and discussions:

Fix: Resolves install failures on certain images due to missing wheels for ciso8601.

📚 Documentation preview 📚: https://meltano-sdk--979.org.readthedocs.build/en/979/

@edgarrmondragon edgarrmondragon force-pushed the refactor/singerlib branch 5 times, most recently from e781ae4 to 9d1ccc9 Compare September 17, 2022 04:28
@codecov
Copy link

codecov bot commented Sep 17, 2022 •
edited
Loading

Codecov Report

Merging #979 (46a8203) into main (a521b23) will increase coverage by 0.60%.
The diff coverage is 97.41%.

@@            Coverage Diff             @@
##             main     #979      +/-   ##
==========================================
+ Coverage   81.57%   82.18%   +0.60%     
==========================================
  Files          35       37       +2     
  Lines        3512     3620     +108     
  Branches      690      722      +32     
==========================================
+ Hits         2865     2975     +110     
+ Misses        482      479       -3     
- Partials      165      166       +1
Impacted Files Coverage Δ
singer_sdk/authenticators.py 64.16% <0.00%> (-0.21%) ⬇️
singer_sdk/streams/core.py 83.14% <88.23%> (-0.12%) ⬇️
singer_sdk/_singerlib/catalog.py 98.14% <93.87%> (ø)
singer_sdk/_singerlib/__init__.py 100.00% <100.00%> (ø)
singer_sdk/_singerlib/messages.py 100.00% <100.00%> (ø)
singer_sdk/_singerlib/schema.py 100.00% <100.00%> (ø)
singer_sdk/helpers/_batch.py 89.36% <100.00%> (-1.03%) ⬇️
singer_sdk/helpers/_catalog.py 71.42% <100.00%> (ø)
singer_sdk/io_base.py 76.47% <100.00%> (ø)
singer_sdk/mapper_base.py 56.14% <100.00%> (ø)
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon force-pushed the refactor/singerlib branch 10 times, most recently from 4fe26bf to 0d30dbe Compare September 19, 2022 15:38
edgarrmondragon
edgarrmondragon commented Sep 19, 2022
View reviewed changes
pyproject.toml Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@edgarrmondragon edgarrmondragon changed the title refactor: Move singer library code into singer_sdk._singerlib refactor: Move singer library code into singer_sdk.singer Sep 19, 2022
@edgarrmondragon edgarrmondragon self-assigned this Sep 19, 2022
edgarrmondragon
edgarrmondragon commented Sep 19, 2022
View reviewed changes
tests/_singerlib/test_schema.py Show resolved Hide resolved
tests/_singerlib/test_catalog.py Outdated Show resolved Hide resolved
@edgarrmondragon edgarrmondragon changed the title refactor: Move singer library code into singer_sdk.singer refactor: Move singer library code into singer_sdk._singerlib Sep 19, 2022
@edgarrmondragon edgarrmondragon changed the title refactor: Move singer library code into singer_sdk._singerlib refactor: Remove dependency on pipelinewise-singer-python and move singer library code into singer_sdk._singerlib` Sep 19, 2022
@edgarrmondragon edgarrmondragon changed the title refactor: Remove dependency on pipelinewise-singer-python and move singer library code into singer_sdk._singerlib` refactor: Remove dependency on pipelinewise-singer-python and move singer library code into singer_sdk._singerlib Sep 19, 2022
@edgarrmondragon edgarrmondragon marked this pull request as ready for review September 20, 2022 00:54
@edgarrmondragon
Copy link
Collaborator Author

@aaronsteers @kgpayne this is ready for review 😄

kgpayne
kgpayne approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@kgpayne kgpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@edgarrmondragon edgarrmondragon enabled auto-merge (squash) September 23, 2022 17:44
aaronsteers
aaronsteers approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@edgarrmondragon edgarrmondragon merged commit 861dfc3 into main Sep 23, 2022
@edgarrmondragon edgarrmondragon deleted the refactor/singerlib branch September 23, 2022 17:52
@edgarrmondragon edgarrmondragon mentioned this pull request Sep 23, 2022
Closed
@edgarrmondragon edgarrmondragon mentioned this pull request Oct 7, 2022
Open
This was referenced Nov 15, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronsteers aaronsteers aaronsteers approved these changes

@kgpayne kgpayne kgpayne approved these changes

@cjohnhanson cjohnhanson Awaiting requested review from cjohnhanson

Assignees

@edgarrmondragon edgarrmondragon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider refactoring external dependencies
3 participants
@edgarrmondragon @kgpayne @aaronsteers