Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Absolute file paths created by taps running in BATCH mode can't be processed by the Sink #999

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Sep 26, 2022

Closes #998


📚 Documentation preview 📚: https://meltano-sdk--999.org.readthedocs.build/en/999/

@edgarrmondragon edgarrmondragon force-pushed the 998-bug-absolute-file-paths-created-by-taps-running-in-batch-mode-cant-be-processed-by-the-sink branch from 2b10e9a to 1f450b1 Compare September 26, 2022 20:54
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #999 (fbe025c) into main (47930d4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #999      +/-   ##
==========================================
+ Coverage   82.17%   82.18%   +0.01%     
==========================================
  Files          37       37              
  Lines        3618     3621       +3     
  Branches      722      722              
==========================================
+ Hits         2973     2976       +3     
  Misses        479      479              
  Partials      166      166              
Impacted Files Coverage Δ
singer_sdk/helpers/_batch.py 89.79% <100.00%> (+0.43%) ⬆️
singer_sdk/sinks/core.py 80.00% <100.00%> (-0.14%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon force-pushed the 998-bug-absolute-file-paths-created-by-taps-running-in-batch-mode-cant-be-processed-by-the-sink branch from 1f450b1 to 9bb7ea1 Compare September 27, 2022 00:50
@edgarrmondragon edgarrmondragon marked this pull request as ready for review September 27, 2022 01:11
Copy link
Contributor

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

…running-in-batch-mode-cant-be-processed-by-the-sink
…running-in-batch-mode-cant-be-processed-by-the-sink
@edgarrmondragon edgarrmondragon merged commit 179d8a9 into main Sep 27, 2022
@edgarrmondragon edgarrmondragon deleted the 998-bug-absolute-file-paths-created-by-taps-running-in-batch-mode-cant-be-processed-by-the-sink branch September 27, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Absolute file paths created by taps running in BATCH mode can't be processed by the Sink
2 participants