-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add method - detect format / data_type #380
Conversation
New update uses a DataType model. This increases type safety and makes it possible to list the accepted data_types. |
if self.config.id is not None: | ||
metadatas = [{**m, "app_id": self.config.id} for m in metadatas] | ||
# Loop though all metadatas and add extras. | ||
new_metadatas = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should append the Successfully saved https://nav.al/agi. New chunks count
print statement. We should show the data type deduced here, so that everyone has visibility of the data type and can corrections if needed.
I know about the logging part, but a lot of users might not use logging. Hence the ask
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea
about the logging: warning and above are displayed by default. lower has to be enabled.
Description
Automatically detect and use the
data_type
inadd
method.breaking change because the first argument of add is now the source/content, not the data type.
Changes the order of arguments, because ``
Fixes #168 #76
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Please delete options that are not relevant.
Checklist:
Maintainer Checklist