Skip to content

Commit

Permalink
MB-17262: correct "show this server" link
Browse files Browse the repository at this point in the history
The "Show this Server" link is shown on the specific state analytics
page. The title of the graph is computed as the IP address of the
host with the port removed if it's 8091. This is done by this bit
of code:
https://github.com/couchbase/ns_server/blob/master/src/menelaus_stats.erl#L2394

What this means is that the title is an incorrect hostname to pass
as the statsHostname parameter when the link is clicked.

What should be passed is the name.slice(1) as is done in the old UI.

Change-Id: I3dd6f00daad09122a980e4e042c48a1190c6d054
Reviewed-on: http://review.couchbase.org/59777
Tested-by: Dave Finlay <dave.finlay@couchbase.com>
Reviewed-by: Pavel Blagodov <stochmail@gmail.com>
  • Loading branch information
dave-finlay authored and pavel-blagodov committed Feb 11, 2016
1 parent 46e2a33 commit 277cdd4
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ <h3 class="block-expander js_block-expander" ng-click="analyticsListCtl.toggleDe
<ul class="js_inner">
<li>
<a ng-show="!analyticsCtl.isSpecificStats" ui-sref="app.admin.analytics.list.graph({graph: '@' + analyticsCtl.nodes.nodesNames[1], specificStat: statInfo.name})">show by server</a>
<a ng-show="analyticsCtl.isSpecificStats" ui-sref="app.admin.analytics.list.graph({graph: 'ops', statsHostname: statInfo.title, specificStat: null})">show this server</a>
<a ng-show="analyticsCtl.isSpecificStats" ui-sref="app.admin.analytics.list.graph({graph: 'ops', statsHostname: statInfo.name.slice(1), specificStat: null})">show this server</a>
</li>
</ul>
</ins>
Expand Down

0 comments on commit 277cdd4

Please sign in to comment.