Skip to content

Commit

Permalink
remove "logger chunks", add individualized streams
Browse files Browse the repository at this point in the history
Stop doing a multi-reader circular buffer structure on top of a circular
buffer. Also adds individualized streams based off of the central buffer.

Sadly this requires managing iovecs and dealing with partial writes into said
iovecs. That makes things very complicated. Since it's not clear to me how to
simplify it too much (as of this writing), one of the next commits should
remove iovecs and instead give each watcher its own circular buffer. The
parser thread will copy watched events into each buffer.

The above would only be slower for the case of many watchers watching the same
event streams. Given all of the extra loops required for managing the iovecs,
and the more complicated syscall handling, it might even be the same speed to
manage multiple buffers anyway.

I completed this intermediary change since it simplifies the surrounding code
and was educational to fiddle with iovecs again.
  • Loading branch information
dormando committed Jun 17, 2016
1 parent 6a4e8e1 commit d5f7f89
Show file tree
Hide file tree
Showing 3 changed files with 180 additions and 151 deletions.

0 comments on commit d5f7f89

Please sign in to comment.