Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DTrace build fix on Mac proposal. #592

Closed
wants to merge 2 commits into from
Closed

DTrace build fix on Mac proposal. #592

wants to merge 2 commits into from

Conversation

devnexen
Copy link
Contributor

The header generated comes with $ IDs thus breaking the build.
The probes are set with const address arguments already
which just add the qualifier again.

@dormando
Copy link
Member

thanks! Fwiw I have no mac right now, so no way to validate this. Would appreciate anyone with a mac who could give it a quick validation/check.

@dormando
Copy link
Member

Yeah, still need someone else with a Mac to come try this. Since you've been doing freebsd patches, I assume you've also tested on freebsd :)

@devnexen devnexen force-pushed the dtrace_macos_build_fix_proposal branch from 8026503 to aad139b Compare January 14, 2020 04:19
@devnexen
Copy link
Contributor Author

Thx for the reminder :-)

@dormando dormando mentioned this pull request Jan 22, 2020
Closed
dormando
dormando reviewed Apr 30, 2020
View reviewed changes
configure.ac Outdated
@@ -177,6 +187,8 @@ if test "x$enable_dtrace" = "xyes"; then
then
dtrace_instrument_obj=yes
rm conftest.h
# on Mac probe id are generated with $
CFLAGS="$CFLAGS -Wno-dollar-in-identifier-extension"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is enabling for freebsd too?

@dormando
Copy link
Member

I want to close this out but I don't have the resources to validate it myself; it looks like it's changing the build around a bit for darwin, which might overlap with other dtrace-enabled OS's.

Need someone else to +1 this. I can try again myself once I've gotten more of the new buildbots running as well, I guess. Either way I'd like to close this out in the next week as it's just hanging around.

@dormando
Copy link
Member

I can see this build failure now. Will take a more careful look when I get a moment.

@dormando
Copy link
Member

@devnexen rebase, address comment, and lets finish this? I have access to a recent mac so can validate. comment was about lack of DARWIN gating for the cflags change. maybe add some comments about why the other changes were done for darwin only?

@devnexen devnexen force-pushed the dtrace_macos_build_fix_proposal branch from aad139b to 92ec7b5 Compare October 27, 2020 22:06
@dormando
Copy link
Member

dormando commented Nov 2, 2020

Fails on my mac:

/usr/sbin/dtrace  -G -o memcached_dtrace.o -s ./memcached_dtrace.d memcached-memcached.o memcached-hash.o memcached-jenkins_hash.o memcached-murmur3_hash.o memcached-slabs.o memcached-items.o memcached-assoc.o memcached-thread.o memcached-daemon.o memcached-stats_prefix.o memcached-util.o memcached-cache.o memcached-bipbuffer.o memcached-logger.o memcached-crawler.o memcached-itoa_ljust.o memcached-slab_automove.o memcached-authfile.o memcached-restart.o memcached-proto_text.o memcached-proto_bin.o      memcached-extstore.o memcached-crc32c.o memcached-storage.o memcached-slab_automove_extstore.o 
Usage: dtrace [-aACeFHlqSvVwZ] [-arch i386|x86_64] [-b bufsz] [-c cmd] [-D name[=def]]
[snip]

(rebased on top of next and tried it, mac should be latest OS)

@devnexen
Copy link
Contributor Author

devnexen commented Nov 2, 2020

It might need System Integrity disabled (at reboot time I think).

@dormando
Copy link
Member

I've no idea what that is :( I was testing with a VM.

@dormando
Copy link
Member

not sure why a system integrity thing would give a dtrace program syntax error though?

@devnexen
Copy link
Contributor Author

The system integrity disallows dtrace to create object files. I found out however in the meantime you can "fine grain" the setting still enabling system integrity but fully enable dtrace capabilities.

@dormando dormando added the MacOS issues/PR's related to mac label Jun 9, 2021
@dormando
Copy link
Member

@devnexen mind rebasing this too? I'd like to either merge or close it today. it's still necessary, yes?

@devnexen
DTrace build fix on Mac proposal.
640db97 
The header generated comes with $ IDs thus breaking the build.
The probes are set with const address arguments already
which just add the qualifier again.
@devnexen devnexen force-pushed the dtrace_macos_build_fix_proposal branch from 92ec7b5 to abdb1a6 Compare August 25, 2022 21:55
@devnexen
Copy link
Contributor Author

seems to be still needed.

@dormando
Copy link
Member

@devnexen point it at next ? sorry!

@dormando dormando changed the base branch from master to next August 25, 2022 22:23
@dormando
Copy link
Member

nevermind I could do it, heh

@dormando
Copy link
Member

@devnexen failing the whitespace test.

@devnexen devnexen force-pushed the dtrace_macos_build_fix_proposal branch from abdb1a6 to fbff5be Compare August 26, 2022 00:24
@dormando
Copy link
Member

released in 1.6.17

@dormando dormando closed this Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dormando dormando dormando left review comments

Assignees
No one assigned
Labels
MacOS issues/PR's related to mac merged/fixed for next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@devnexen @dormando