Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Get Quietly, Get Key, Get Key Quietly methods #42

Closed
chylvina opened this issue Feb 20, 2014 · 6 comments
Closed

Add Get Quietly, Get Key, Get Key Quietly methods #42

chylvina opened this issue Feb 20, 2014 · 6 comments

Comments

@chylvina
Copy link

According to https://code.google.com/p/memcached/wiki/MemcacheBinaryProtocol, do you have a plan to add these 3 method?

And I can help if needed.

@chylvina
Copy link
Author

and
4.6. quit

@alevy
Copy link
Member

alevy commented Feb 20, 2014

I don't think the get variants are valuable to expose in the client interface (it's useful as a building block for higher level operations like multi-get, or for handling get requests asynchronously).

Multi-get would certainly be valuable (often implemented as a series of get-key-quietly so) although I haven't thought through whether it would require any significant changes in how callbacks are invoked in server.js

Fairly simple but useful features that I would be thrilled if you submitted a patch for (no one has asked for these yet, but they should be there):

  • Append/prepend
  • An optimization of set to use set-quietly when a callback isn't passed. SetQ isn't documented as well as getq, but basically it only responds if there was an error (which if there is no callback should probably just be discarded).
  • Touch command

Thanks for your interest! BTW, you probably want to be looking at this wiki page which is slightly more up to date: http://code.google.com/p/memcached/wiki/BinaryProtocolRevamped

@alevy
Copy link
Member

alevy commented Feb 20, 2014

we could, in principal add quit commands to the Client#close function, i'm not against that - it's more polite to the server even if not strictly necessary.

@chylvina
Copy link
Author

OK, I'll check it out first.

@alevy
Copy link
Member

alevy commented Apr 8, 2014

@chylvina any news?

@dterei dterei changed the title Add Get Quietly, Get Key, Get Key Quietly method Add Get Quietly, Get Key, Get Key Quietly methods Apr 19, 2016
@dterei
Copy link
Collaborator

dterei commented Apr 29, 2016

Closing as we support touch, quit, prepend... just not multi-get and others, but we have that documented elsewhere.

@dterei dterei closed this as completed Apr 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants