Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preferences: fix left-chat #64

Closed
xDashh opened this issue May 30, 2018 · 3 comments
Closed

preferences: fix left-chat #64

xDashh opened this issue May 30, 2018 · 3 comments
Assignees
@kenany
Labels
bug frontend

Comments

@xDashh
Copy link
Member

xDashh commented May 30, 2018

Multiple reports of left-chat not working reliably. Need to figure out details.
@xDashh
Copy link
Member Author

xDashh commented Jun 4, 2018

My reproducible tests don't work anymore and no more complaints lately. Some recent change or maybe just a rebuild might have fixed something, closing until new reports 🤔

@xDashh xDashh closed this as completed Jun 4, 2018
@xDashh
Copy link
Member Author

xDashh commented Jun 4, 2018

Happening again, probably reproducible. Seems related to user-specified pages only.

@xDashh xDashh reopened this Jun 4, 2018
@xDashh xDashh removed the needs-repro label Jun 4, 2018
@kenany
Copy link
Member

kenany commented Jun 4, 2018

I think the bug is here. If it's a /:streamer stream, then we set the document title and the stream, but we do not call this.props.fetchProfileIfLoggedIn() like we do in the /:service/:channel case, because of that early return on line 121. So, for the former kind of streams the profile is never fetched and hence left-chat is always the default: disabled.

@kenany kenany self-assigned this Jul 3, 2018
kenany added a commit that referenced this issue Jul 3, 2018
@kenany
fix left-chat on user pages
152fad0 
Fixes #64
@kenany kenany mentioned this issue Jul 3, 2018
Merged
@kenany kenany closed this as completed in #74 Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kenany kenany

Labels
bug frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kenany @xDashh