bootstrap_servers argument usage #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| servers_field = f"'{self.bootstrap_servers}'" | ||
| else: | ||
| servers_field = str(self.bootstrap_servers)[1:-1] | ||
| query += f" BOOTSTRAP_SERVERS {servers_field}" |
There was a problem hiding this comment.
Consider changing this if-else into one-liner
There was a problem hiding this comment.
can you help me understand how? Something like:
servers_field = f"'{self.bootstrap_servers}'" if isinstance(self.bootstrap_servers, str) else str(self.bootstrap_servers)[1:-1]
Seems too long
There was a problem hiding this comment.
Python is known for such long statements. But i stated "consider", not "rewrite"
BorisTasevski
approved these changes
Mar 8, 2022
Josipmrden
approved these changes
Mar 8, 2022
|
Build and Test fails because of pymgclient version 1.1.0 in pyproject.toml and poetry.lock, this is not an issue here as it is like this in develop branch |
g-despot
approved these changes
Mar 9, 2022
g-despot
deleted the
93-allow-bootstrap_servers-argument-usage-without-quotes
branch
g-despot
restored the
93-allow-bootstrap_servers-argument-usage-without-quotes
branch
brunos252
deleted the
93-allow-bootstrap_servers-argument-usage-without-quotes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
bootstrap_serversargument to accept unquoted values and lists of unquoted values.